(#359) Datacenter support to consul_key_value #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
same problem with travis, i asked their support for help |
houtmanj
force-pushed
the
fix2
branch
2 times, most recently
from
cd70122
to
d2ed2b5
Compare
|
This looks pretty good. Can you expand the section on the k/v in the README and then I'll merge and make a major release. |
solarkennedy
approved these changes
Sep 11, 2017
|
Sure,
If you can want to wait a little longer.
I was planning on optimizing the code so that we only update consul when we
need changes.
And if you want it in the module:
I am starting to build a function to query the kv.
Something along the lines of:
$data = consul::key_value_query(path)
Jos
…On Mon, 11 Sep 2017 at 16:46, Kyle Anderson ***@***.***> wrote:
This looks pretty good. Can you expand the section on the k/v in the
README and then I'll merge and make a major release.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#365 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAo8rsjAd5ewg6pIxkAh8Vur8EPyNepIks5shUfBgaJpZM4PQ4El>
.
|
|
Any chance we can see this merged? |
solarkennedy
reviewed
Oct 2, 2017
README.md
Outdated
| This provider allows you to manage key/value pairs. It tries to be smart in two ways: | ||
|
|
||
| 1. It caches the data accessible from the kv store with the specified acl token. | ||
| 2. It does not update the key if the value & flag are allready correct. |
README.md
Outdated
|
|
||
| Allowed parameters for this type and their default values: | ||
|
|
||
| Name | Default value | Comments |
There was a problem hiding this comment.
Can you make this more "markdown"y?
|
omg once again I neglected to click the "submit review" button which has delayed this. @houtmanj please fix the few minor issues and I will merge. It is ok to add future functions in a new PR. |
added 6 commits
October 3, 2017 06:24
This includes tests for the provider that mock the consul API.
$ bundle install --without development --path=${BUNDLE_PATH:-vendor/bundle}
Fetching gem metadata from https://rubygems.org/...Retrying dependency
api due to error (2/3): Bundler::HTTPError Net::HTTPClientError: Too
many gems! (use --full-index instead)
Retrying dependency api due to error (3/3): Bundler::HTTPError
Net::HTTPClientError: Too many gems! (use --full-index instead)
public_suffix is pinned to a version that supports ruby 1.9.3. puppet is updated to 3.8.4 since that is the minimal version for the tests.
Test if the value in the keyvalue store is allready what we want it to be and skip the update. Value and flags are both tested.
|
This what you intended? |
|
Looks great! |
spuder
pushed a commit
to spuder/puppet-consul
that referenced
this pull request
Feb 25, 2020
(voxpupuli#359) Datacenter support to consul_key_value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes tests for the provider that mock the consul API
Fixes #363