Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate config file before deploying #372

Merged
merged 1 commit into from
Oct 13, 2017

Conversation

kasimon
Copy link
Contributor

@kasimon kasimon commented Oct 13, 2017

Use validate_cmd to check the config file for validity before actually installing it.

Use validate_cmd to check the config file for validity before actually installing it.
@solarkennedy
Copy link
Contributor

Hmm. This seems like a good idea. It does imply that the consul binary is installed and ready to go. Seems legit.

@solarkennedy solarkennedy merged commit 8d16a81 into voxpupuli:master Oct 13, 2017
@kasimon
Copy link
Contributor Author

kasimon commented Oct 14, 2017

Yes, the binary has to be present, but it does not have to be set up in any way. The validation happens independently from the normal service setup.

Thanks for merging!

@wyardley
Copy link

wyardley commented Nov 14, 2017

I know there is a compatibility matrix in the README, but this does break consul on versions where the version doesn't yet support consul validate. Maybe there should be a conditional based on consul version?

Also, I think this breaks the default config? The module default in params.pp seems to be 0.7.4 (https://github.com/solarkennedy/puppet-consul/blob/master/manifests/params.pp#L44), even though the readme says current is >= 0.8.0. So either default should be updated to 0.8.5 (or 1.x), or the validation should be skipped when the version doesn't support it.

spuder pushed a commit to spuder/puppet-consul that referenced this pull request Feb 25, 2020
Validate config file before deploying
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants