Skip to content

Commit

Permalink
feat: Create UnionHandler to combine AsyncHandler results
Browse files Browse the repository at this point in the history
  • Loading branch information
joachimvh committed Sep 28, 2021
1 parent c3fa74d commit 62f026f
Show file tree
Hide file tree
Showing 3 changed files with 159 additions and 0 deletions.
1 change: 1 addition & 0 deletions src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -318,6 +318,7 @@ export * from './util/handlers/ConditionalHandler';
export * from './util/handlers/ParallelHandler';
export * from './util/handlers/SequenceHandler';
export * from './util/handlers/StaticHandler';
export * from './util/handlers/UnionHandler';
export * from './util/handlers/UnsupportedAsyncHandler';
export * from './util/handlers/WaterfallHandler';

Expand Down
94 changes: 94 additions & 0 deletions src/util/handlers/UnionHandler.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,94 @@
import { AsyncHandler } from './AsyncHandler';
import { createAggregateError, filterHandlers, findHandler } from './HandlerUtil';

// Helper types to make sure the UnionHandler has the same in/out types as the AsyncHandler type it wraps
type ThenArg<T> = T extends PromiseLike<infer U> ? U : T;
type InType<T extends AsyncHandler<any, any>> = Parameters<T['handle']>[0];
type OutType<T extends AsyncHandler<any, any>> = ThenArg<ReturnType<T['handle']>>;
type HandlerType<T extends AsyncHandler> = AsyncHandler<InType<T>, OutType<T>>;

/**
* Utility handler that allows combining the results of multiple handlers into one.
* Will run all the handlers and then call the abstract `combine` function with the results,
* which should return the output of the class.
*
* If `requireAll` is true, the handler will fail if any of the handlers do not support the input.
* If `requireAll` is false, only the handlers that support the input will be called,
* only if all handlers reject the input will this handler reject as well.
* With `requireAll` set to false, the length of the input array
* for the `combine` function is variable (but always at least 1).
*/
export abstract class UnionHandler<T extends AsyncHandler<any, any>> extends AsyncHandler<InType<T>, OutType<T>> {
protected readonly handlers: T[];
private readonly requireAll: boolean;

protected constructor(handlers: T[], requireAll = false) {
super();
this.handlers = handlers;
this.requireAll = requireAll;
}

public async canHandle(input: InType<T>): Promise<void> {
if (this.requireAll) {
await this.allCanHandle(input);
} else {
// This will error if no handler supports the input
await findHandler(this.handlers, input);
}
}

public async handle(input: InType<T>): Promise<OutType<T>> {
let handlers: HandlerType<T>[];
if (this.requireAll) {
// Handlers were already checked in canHandle
// eslint-disable-next-line prefer-destructuring
handlers = this.handlers;
} else {
handlers = await filterHandlers(this.handlers, input);
}

const results = await Promise.all(
handlers.map(async(handler): Promise<OutType<T>> => handler.handle(input)),
);

return this.combine(results);
}

public async handleSafe(input: InType<T>): Promise<OutType<T>> {
let handlers: HandlerType<T>[];
if (this.requireAll) {
await this.allCanHandle(input);
// eslint-disable-next-line prefer-destructuring
handlers = this.handlers;
} else {
// This will error if no handler supports the input
handlers = await filterHandlers(this.handlers, input);
}

const results = await Promise.all(
handlers.map(async(handler): Promise<OutType<T>> => handler.handle(input)),
);

return this.combine(results);
}

/**
* Checks if all handlers can handle the input.
* If not, throw an error based on the errors of the failed handlers.
*/
private async allCanHandle(input: InType<T>): Promise<void> {
const results = await Promise.allSettled(this.handlers.map(async(handler): Promise<HandlerType<T>> => {
await handler.canHandle(input);
return handler;
}));
if (results.some(({ status }): boolean => status === 'rejected')) {
const errors = results.map((result): Error => (result as PromiseRejectedResult).reason);
throw createAggregateError(errors);
}
}

/**
* Combine the results of the handlers into a single output.
*/
protected abstract combine(results: OutType<T>[]): Promise<OutType<T>>;
}
64 changes: 64 additions & 0 deletions test/unit/util/handlers/UnionHandler.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
import type { AsyncHandler } from '../../../../src/util/handlers/AsyncHandler';
import { UnionHandler } from '../../../../src/util/handlers/UnionHandler';

class SimpleUnionHandler extends UnionHandler<AsyncHandler<any, string>> {
public constructor(handlers: AsyncHandler<any, any>[], requireAll?: boolean) {
super(handlers, requireAll);
}

protected async combine(results: string[]): Promise<string> {
return results.join('');
}
}

describe('A UnionHandler', (): void => {
const input = { data: 'text' };
let handlers: jest.Mocked<AsyncHandler<any, string>>[];
let handler: SimpleUnionHandler;

beforeEach(async(): Promise<void> => {
handlers = [
{ canHandle: jest.fn(), handle: jest.fn().mockResolvedValue('a') } as any,
{ canHandle: jest.fn(), handle: jest.fn().mockResolvedValue('b') } as any,
];

handler = new SimpleUnionHandler(handlers);
});

it('can handle a request if at least one extractor can handle it.', async(): Promise<void> => {
await expect(handler.canHandle(input)).resolves.toBeUndefined();

handlers[0].canHandle.mockRejectedValue(new Error('bad request'));
await expect(handler.canHandle(input)).resolves.toBeUndefined();

handlers[1].canHandle.mockRejectedValue(new Error('bad request'));
await expect(handler.canHandle(input)).rejects.toThrow('bad request');

await expect(handler.handleSafe(input)).rejects.toThrow('bad request');
});

it('requires all handlers to support the input if requireAll is true.', async(): Promise<void> => {
handler = new SimpleUnionHandler(handlers, true);
await expect(handler.canHandle(input)).resolves.toBeUndefined();

handlers[0].canHandle.mockRejectedValue(new Error('bad request'));
await expect(handler.canHandle(input)).rejects.toThrow('bad request');

await expect(handler.handleSafe(input)).rejects.toThrow('bad request');
});

it('calls all handlers that support the input.', async(): Promise<void> => {
handlers[0].canHandle.mockRejectedValue(new Error('bad request'));
await expect(handler.handle(input)).resolves.toBe('b');
await expect(handler.handleSafe(input)).resolves.toBe('b');
});

it('calls all handlers if requireAll is true.', async(): Promise<void> => {
handler = new SimpleUnionHandler(handlers, true);
await expect(handler.handleSafe(input)).resolves.toBe('ab');

// `handle` call does not need to check `canHandle` values anymore
handlers[0].canHandle.mockRejectedValue(new Error('bad request'));
await expect(handler.handle(input)).resolves.toBe('ab');
});
});

0 comments on commit 62f026f

Please sign in to comment.