Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chassis: test_show_pfc_counters fails since show pfc counters does not include inband and recycle ports #10250

Open
mannytaheri opened this issue Mar 16, 2022 · 2 comments
Assignees
Labels
Chassis 🤖 Modular chassis support MSFT Triaged this issue has been triaged

Comments

@mannytaheri
Copy link

mannytaheri commented Mar 16, 2022

Description

test_show_pfc_counters fails since show pfc counters does not include inband and recycle ports.
"show interface counters" includes inband and recycle ports and it passes

mode = 'alias'
It searches for each alias from port_alias_map in the output of "SONIC_CLI_IFACE_MODE=alias sudo show pfc counters"
It does not find aliases associated with Inband ports (Ethernet-IB0, Ethernet-IB1) or recycle ports (Ethernet-Rec0, Ethernet-Rec1) in pfc_rx or pfc_tx counters

mode = 'default'
It searches for each interface from port_name_map in the output of "SONIC_CLI_IFACE_MODE=default sudo show pfc counters"
It does not find Inband ports (Ethernet-IB0, Ethernet-IB1) or recycle ports (Ethernet-Rec0, Ethernet-Rec1) in pfc_rx or pfc_tx counters

show interface counters
IFACE STATE RX_OK RX_BPS RX_UTIL RX_ERR RX_DRP
Ethernet0 X 0 0.00 B/s 0.00% 0 0
...
Ethernet-IB0 U 4 0.00 B/s 0.00% 0 0
Ethernet-Rec0 X 0 0.00 B/s 0.00% 0 0
Ethernet18 X 0 0.00 B/s 0.00% 0 0
....
Ethernet35 X 0 0.00 B/s 0.00% 0 0
Ethernet-IB1 U 3 0.00 B/s 0.00% 0 0
Ethernet-Rec1 X 0 0.00 B/s 0.00% 0 0

show pfc counters
Port Rx PFC0 PFC1 PFC2 PFC3 PFC4 PFC5 PFC6 PFC7

Ethernet0 0 0 0 0 0 0 0 0
Ethernet1 0 0 0 0 0 0 0 0
...
Ethernet34 0 0 0 0 0 0 0 0
Ethernet35 0 0 0 0 0 0 0 0

Steps to reproduce the issue:

  1. Run test_show_pfc_counters

Describe the results you received:

E AssertionError
ifmode = 'default'
intf = 'Ethernet-Rec1'

checking for 'Ethernet-Rec1 in the output of show pfc counter but it does not exist.

Describe the results you expected:

No AssertionError

Output of show version:

(paste your output here)

Output of show techsupport:

(paste your output here or download and attach the file here )

Additional information you deem important (e.g. issue happens only occasionally):

@zhangyanzhao zhangyanzhao added Triaged this issue has been triaged MSFT Chassis 🤖 Modular chassis support labels Mar 30, 2022
@rlhui rlhui assigned arlakshm and unassigned rlhui May 25, 2022
@abdosi
Copy link
Contributor

abdosi commented Aug 17, 2022

@vmittal-msft please see if any particular handling is needed for Recycle and Inband ports from PFC perspective.

@arlakshm
Copy link
Contributor

Fix the show interface counters not to display the Inband ports in this PR #11764

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chassis 🤖 Modular chassis support MSFT Triaged this issue has been triaged
Projects
None yet
Development

No branches or pull requests

6 participants