celestica get_cpld_reg_value needs to clean output

[kdienes]

In the revised get_cpld_reg_value:

sonic-buildimage/device/celestica/x86_64-cel_seastone-r0/sonic_platform/helper.py

Line 81 in 220ea74

return result

the function leaves the '\n' on the string,

which means that in

sonic-buildimage/device/celestica/x86_64-cel_seastone-r0/sonic_platform/watchdog.py

Line 103 in 220ea74

def _gettimeout(self):

the hex_time has embedded '\n' and cannot parse.

Adding .rstrip() to get_cpld_reg_value seems to fix the issue but since I'm not sure if it should be stripped in _gettimeout or get_cpld_reg_value I'm leaving this as an Issue and not a PR.

[judyjoseph]

@kdienes please add more details. @prgeor, can you check on this

[kdienes]

Happy to add more details; just let me know what you need. As one example:

def _gettimeout(self):
        h_bit = self._api_helper.get_cpld_reg_value(self.getreg_path, WDT_TIMER_H_BIT_REG)
        m_bit = self._api_helper.get_cpld_reg_value(self.getreg_path, WDT_TIMER_M_BIT_REG)
        l_bit = self._api_helper.get_cpld_reg_value(self.getreg_path, WDT_TIMER_L_BIT_REG)

        hex_time = '0x{}{}{}'.format(h_bit[2:], m_bit[2:], l_bit[2:])
        ms = int(hex_time, 16)
        return int(float(ms)/1000)

So when get_cpld_reg_value() leaves the \n on the end of the string, hex_time ends up unparseable as an int.

[qnos]

PR #15371 fixes the issue. It strip the '\n' in helper api.

[prgeor]

@qnos for confirming. @kdienes closing for now, please verify the fix

[prgeor]

@judyjoseph FYI