SAI_STATUS_NOT_IMPLEMENTED being reported for get_bridge_port_attribute() with SAI header 1.3 change

[jipanyang]

With this commit 51bfc2e or this PR #1778

hitting the SAI_STATUS_NOT_IMPLEMENTED error for sai_bridge_api->get_bridge_port_attribute() on broadcom tomahawk chip. It happened in void PortsOrch::removeDefaultBridgePorts() which is at contruct phase of portorch.

sairedis.rec

2018-07-06.21:16:24.747822|g|SAI_OBJECT_TYPE_BRIDGE:oid:0x39000000000047|SAI_BRIDGE_ATTR_PORT_LIST=57:oid:0x0,oid:0x0,oid:0x0,oid:0x0,oid:0x0,oid:0x0,oid:0x0,oid:0x0,oid:0x0,oid:0x0,oid:0x0,oid:0x0,oid:0x0,oid:0x0,oid:0x0,oid:0x0,oid:0x0,oid:0x0,oid:0x0,oid:0x0,oid:0x0,oid:0x0,oid:0x0,oid:0x0,oid:0x0,oid:0x0,oid:0x0,oid:0x0,oid:0x0,oid:0x0,oid:0x0,oid:0x0,oid:0x0,oid:0x0,oid:0x0,oid:0x0,oid:0x0,oid:0x0,oid:0x0,oid:0x0,oid:0x0,oid:0x0,oid:0x0,oid:0x0,oid:0x0,oid:0x0,oid:0x0,oid:0x0,oid:0x0,oid:0x0,oid:0x0,oid:0x0,oid:0x0,oid:0x0,oid:0x0,oid:0x0,oid:0x0
2018-07-06.21:16:24.753660|G|SAI_STATUS_SUCCESS|SAI_BRIDGE_ATTR_PORT_LIST=56:oid:0x3a000000000082,oid:0x3a000000000083,oid:0x3a000000000084,oid:0x3a000000000085,oid:0x3a000000000086,oid:0x3a000000000087,oid:0x3a000000000088,oid:0x3a000000000089,oid:0x3a00000000008a,oid:0x3a00000000008b,oid:0x3a00000000008c,oid:0x3a00000000008d,oid:0x3a00000000008e,oid:0x3a00000000008f,oid:0x3a000000000090,oid:0x3a000000000091,oid:0x3a000000000092,oid:0x3a000000000093,oid:0x3a000000000094,oid:0x3a000000000095,oid:0x3a000000000096,oid:0x3a000000000097,oid:0x3a000000000098,oid:0x3a000000000099,oid:0x3a00000000009a,oid:0x3a00000000009b,oid:0x3a00000000009c,oid:0x3a00000000009d,oid:0x3a00000000009e,oid:0x3a00000000009f,oid:0x3a0000000000a0,oid:0x3a0000000000a1,oid:0x3a0000000000a2,oid:0x3a0000000000a3,oid:0x3a0000000000a4,oid:0x3a0000000000a5,oid:0x3a0000000000a6,oid:0x3a0000000000a7,oid:0x3a0000000000a8,oid:0x3a0000000000a9,oid:0x3a0000000000aa,oid:0x3a0000000000ab,oid:0x3a0000000000ac,oid:0x3a0000000000ad,oid:0x3a0000000000ae,oid:0x3a0000000000af,oid:0x3a0000000000b0,oid:0x3a0000000000b1,oid:0x3a0000000000b2,oid:0x3a0000000000b3,oid:0x3a0000000000b4,oid:0x3a0000000000b5,oid:0x3a0000000000b6,oid:0x3a0000000000b7,oid:0x3a0000000000b8,oid:0x3a0000000000b9
2018-07-06.21:16:24.754243|g|SAI_OBJECT_TYPE_BRIDGE_PORT:oid:0x3a000000000082|SAI_BRIDGE_PORT_ATTR_TYPE=SAI_BRIDGE_PORT_TYPE_PORT
2018-07-06.21:16:24.755566|G|SAI_STATUS_NOT_IMPLEMENTED|
root@sonic:/var/log/swss# 

syslog

Jul  6 21:16:24.754878 sonic INFO syncd/syncd: :- processEvent: key: SAI_OBJECT_TYPE_BRIDGE_PORT:oid:0x3a000000000082 op: get
Jul  6 21:16:24.754878 sonic INFO syncd/syncd: :- internal_syncd_get_send: sending response for GET api with status: SAI_STATUS_NOT_IMPLEMENTED
Jul  6 21:16:24.755134 sonic INFO syncd/syncd: :- internal_syncd_get_send: response for GET api was send
Jul  6 21:16:24.755817 sonic ERR swss/orchagent: :- meta_sai_get_oid: get status: SAI_STATUS_NOT_IMPLEMENTED
Jul  6 21:16:24.755953 sonic ERR swss/orchagent: :- removeDefaultBridgePorts: Failed to get bridge port type, rv:-15

debug output

root@sonic:/var/log/swss# bcmcmd version
version
Broadcom Command Monitor: Copyright (c) 1998-2018 Broadcom
Release: sdk-6.5.10 built 20180625 (Mon Jun 25 20:36:55 2018)
From sonicbld@63cdb2b17469:/var/sonicbld/workspace/Build/broadcom/broadcom_sai/10-sdk-build-brcm-1.2/bcmsdk
Platform: X86
OS: Unix (Posix)
Chips:
      
      
      
      
      
      
      
      
      
       BCM56640_A0,
      
       BCM56850_A0,
       BCM56340_A0,
       BCM56960_A0,
      
      
      
       BCM56970_A0,
PHYs:  BCM5400, BCM54182, BCM54185, BCM54180,
    BCM54140, BCM54192, BCM54195, BCM54190,
    BCM54194, BCM54210, BCM54220, BCM54280,
    BCM54282, BCM54240, BCM54285, BCM5428X,
    BCM54290, BCM54292, BCM54294, BCM54295,
    BCM54296, BCM84328, Sesto, copper sfp

[jipanyang]

With the sai.mk update, this error is gone. thanks.