[Sflow]: Samples are received by collector even after deleting collector through cli

[chitra-raghavan]

Description

Samples are received by Sflow collector even after deleting collector through cli

1. Config Collector

	root@vlab-01:~#
	root@vlab-01:~# config sflow collector add C1 10.1.0.32 --port 6344
	root@vlab-01:~#
	root@vlab-01:~# show sflow
	
	sFlow Global Information:
	sFlow Admin State:          up
	sFlow Polling Interval:     20
	sFlow AgentID:              default
	
	1 Collectors configured:
		Name: C1                  IP addr: 10.1.0.32  UDP port: 6344
	root@vlab-01:~#

2. Check samples with sflowtool

	root@vlab-01:~# sflowtool -l -p 6344
	CNTR,10.250.0.101,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0
	CNTR,10.250.0.101,76,6,40000000000,0,2,0,0,0,0,0,0,0,0,0,0,0,0,0,0
	CNTR,10.250.0.101,75,6,40000000000,0,3,0,0,0,0,0,0,0,0,0,0,0,0,0,0
	CNTR,10.250.0.101,73,6,40000000000,0,3,0,0,0,0,0,0,0,0,0,0,0,0,0,0
	CNTR,10.250.0.101,63,6,40000000000,0,3,0,0,0,0,0,0,0,0,0,0,0,0,0,0
	CNTR,10.250.0.101,62,6,40000000000,0,3,0,0,0,0,0,0,0,0,0,0,0,0,0,0
	CNTR,10.250.0.101,59,6,40000000000,0,3,0,0,0,0,0,0,0,0,0,0,0,0,0,0
	CNTR,10.250.0.101,54,6,40000000000,0,3,0,0,0,0,0,0,0,0,0,0,0,0,0,0
	CNTR,10.250.0.101,51,6,40000000000,0,3,0,0,0,0,0,0,0,0,0,0,0,0,0,0
	CNTR,10.250.0.101,50,6,40000000000,0,3,0,0,0,0,0,0,0,0,0,0,0,0,0,0
	CNTR,10.250.0.101,40,6,40000000000,0,3,0,0,4294967295,4294967295,0,0,4294967295,0,0,4294967295,4294967295,0,0,0
	CNTR,10.250.0.101,38,6,40000000000,0,3,0,0,4294967295,4294967295,0,0,4294967295,0,0,4294967295,4294967295,0,0,0
	CNTR,10.250.0.101,37,6,40000000000,0,3,0,0,4294967295,4294967295,0,0,4294967295,0,0,4294967295,4294967295,0,0,0

3. Delete Collector

	root@vlab-01:~# config sflow  collector del C1
	root@vlab-01:~# show sflow
	
	sFlow Global Information:
	sFlow Admin State:          up
	sFlow Polling Interval:     20
	sFlow AgentID:              default
	
	0 Collectors configured:

4. Check for samples . It continues to receive samples

	root@vlab-01:~#  sflowtool -l -p 6344
	CNTR,10.250.0.101,76,6,40000000000,0,2,0,0,0,0,0,0,0,0,0,0,0,0,0,0
	CNTR,10.250.0.101,75,6,40000000000,0,3,0,0,0,0,0,0,0,0,0,0,0,0,0,0
	CNTR,10.250.0.101,73,6,40000000000,0,3,0,0,0,0,0,0,0,0,0,0,0,0,0,0
	CNTR,10.250.0.101,63,6,40000000000,0,3,0,0,0,0,0,0,0,0,0,0,0,0,0,0
	CNTR,10.250.0.101,62,6,40000000000,0,3,0,0,0,0,0,0,0,0,0,0,0,0,0,0
	CNTR,10.250.0.101,59,6,40000000000,0,3,0,0,0,0,0,0,0,0,0,0,0,0,0,0
	CNTR,10.250.0.101,54,6,40000000000,0,3,0,0,0,0,0,0,0,0,0,0,0,0,0,0
	CNTR,10.250.0.101,51,6,40000000000,0,3,0,0,0,0,0,0,0,0,0,0,0,0,0,0
	CNTR,10.250.0.101,50,6,40000000000,0,3,0,0,0,0,0,0,0,0,0,0,0,0,0,0
	CNTR,10.250.0.101,40,6,40000000000,0,3,0,0,4294967295,4294967295,0,0,4294967295,0,0,4294967295,4294967295,0,0,0
	CNTR,10.250.0.101,38,6,40000000000,0,3,0,0,4294967295,4294967295,0,0,4294967295,0,0,4294967295,4294967295,0,0,0
	CNTR,10.250.0.101,37,6,40000000000,0,3,0,0,4294967295,4294967295,0,0,4294967295,0,0,4294967295,4294967295,0,0,0

Steps to reproduce the issue:
1.Config and delete sflow collector
2.Check if samples are not received after deletion

Describe the results you received:

Describe the results you expected:

• After deleting the device should not send samples to collector

Additional information you deem important (e.g. issue happens only occasionally):

Tested in SONIC Vs

**Output of `show version`:**

    root@vlab-01:~# show vers

SONiC Software Version: SONiC.HEAD.188-4458efbd
Distribution: Debian 9.11
Kernel: 4.9.0-9-2-amd64
Build commit: 4458efbd
Build date: Wed Dec 18 08:42:30 UTC 2019
Built by: johnar@jenkins-worker-11

Platform: x86_64-kvm_x86_64-r0
HwSKU: Force10-S6000
ASIC: vs
Serial Number: 000000
Uptime: 10:03:26 up 58 min,  1 user,  load average: 0.41, 0.27, 0.30

Docker images:
REPOSITORY                 TAG                 IMAGE ID            SIZE
docker-syncd-vs            HEAD.188-4458efbd   495cc11160dd        291MB
docker-syncd-vs            latest              495cc11160dd        291MB
docker-platform-monitor    HEAD.188-4458efbd   07626700bce9        333MB
docker-platform-monitor    latest              07626700bce9        333MB
docker-fpm-frr             HEAD.188-4458efbd   5b99dc1e2a92        325MB
docker-fpm-frr             latest              5b99dc1e2a92        325MB
docker-lldp-sv2            HEAD.188-4458efbd   f40b3e9c0a24        303MB
docker-lldp-sv2            latest              f40b3e9c0a24        303MB
docker-dhcp-relay          HEAD.188-4458efbd   f56f85f26935        290MB
docker-dhcp-relay          latest              f56f85f26935        290MB
docker-database            HEAD.188-4458efbd   452bb9eae044        282MB
docker-database            latest              452bb9eae044        282MB
docker-sflow               HEAD.188-4458efbd   a7b040a3c4f1        305MB
docker-sflow               latest              a7b040a3c4f1        305MB
docker-teamd               HEAD.188-4458efbd   05a8b6083599        305MB
docker-teamd               latest              05a8b6083599        305MB
docker-snmp-sv2            HEAD.188-4458efbd   35d2e24c3598        339MB
docker-snmp-sv2            latest              35d2e24c3598        339MB
docker-orchagent           HEAD.188-4458efbd   71397b40a481        323MB
docker-orchagent           latest              71397b40a481        323MB
docker-sonic-telemetry     HEAD.188-4458efbd   8cca2b75a13d        305MB
docker-sonic-telemetry     latest              8cca2b75a13d        305MB
docker-router-advertiser   HEAD.188-4458efbd   820d05e70b3c        282MB
docker-router-advertiser   latest              820d05e70b3c        282MB

root@vlab-01:~#

**Attach debug file `sudo generate_dump`:**

```
(paste your output here)
```

[jeff-yin]

hsflowd was not deleting the last sflow collector once it was removed. Padman has notified InMon of the issue and their latest hsflowd version should address this issue.