-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PortChannel mtu change fails with CLI #6430
PortChannel mtu change fails with CLI #6430
Comments
Issue seen in 201906, also seen on master as well. |
I am preparing PR, which will bring support of PortChannels into portconfig script. Currently, I am checking unit tests of sonic-utilities for possibility to add new cases, according to the changes. Could I ask you to review sonic-net/sonic-utilities#1375? |
I have checked unit tests and found there is no tests, related to |
Dear @maksymbelei95, |
Dear @anamehra, Thank you for review, I have added new PR for branch 201911: sonic-net/sonic-utilities#1384 Dear @gechiang, Will be glad if you review PRs sonic-net/sonic-utilities#1375 and sonic-net/sonic-utilities#1384. |
@gechiang would check |
Description
PortChannel mtu change fails with CLI
root@FC0:/home# config interface mtu PortChannel20 1510
Invalid port specified
Steps to reproduce the issue:
Describe the results you received:
Invalid port specified
Describe the results you expected:
The CLI should succeed and portchannel MTU should be updated
Additional information you deem important (e.g. issue happens only occasionally):
The CLI port changes are handled by /usr/bin/portconfig (sonic-utilities/scripts/portconfig) and as per current code, it handles it for only "PORT" table which is for port names starting with "Ethernet". It does not handle PORTCHANNEL table which handles the port names starting with "PortChannel".
This code needs to have handling like following at all locations where port tables are handled:
if port.startswith("Ethernet"):
port_tables = self.db.get_table(PORT_TABLE_NAME)
elif port.startswith("PortChannel"):
port_tables = self.db.get_table(PORTCHANNEL_TABLE_NAME)
sonic-utilities @ c2c4c0d
```
The text was updated successfully, but these errors were encountered: