Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fast-reboot] Reduce time for QosOrch by not query 7x queues #1905

Closed
kcudnik opened this issue Sep 14, 2021 · 3 comments
Closed

[fast-reboot] Reduce time for QosOrch by not query 7x queues #1905

kcudnik opened this issue Sep 14, 2021 · 3 comments
Assignees

Comments

@kcudnik
Copy link
Contributor

kcudnik commented Sep 14, 2021

time should be reduced from 6 sec to about 1.5 sec

Please refer here sonic-net/sonic-buildimage#8428

@stephenxs
Copy link
Collaborator

Just FYI.
The QoS orchagent calls SAI APIs to get the number of child scheduler groups and then initialize them.
After that, the size of child scheduler groups vector will be non-zero, which indicates the child scheduler groups have been initialized and prevent QoS orchagent from calling SAI APIs.
However, on Mellanox platform, some scheduler groups don't have child group, leaving size of child scheduler groups always being zero.
This causes QoS orchagent to call the SAI API each time the scheduler group is handled.
This can be fixed by introducing another flag indicating whether the child group size has been initialized.

@stephenxs
Copy link
Collaborator

Fixed by #1965

@kcudnik
Copy link
Contributor Author

kcudnik commented Sep 25, 2023

Closing since fixed

@kcudnik kcudnik closed this as completed Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants