From 4ace1e49c9ea331144636dbd254c030ae3ff4e33 Mon Sep 17 00:00:00 2001 From: Hidenori Matsubayashi Date: Thu, 28 Sep 2023 11:46:45 +0000 Subject: [PATCH] WAR: temporarily disable partial repaints This change disables the partial repaints temporarily because of the flicker issue. Once the root cause in flutter/engine was fixed and its change propagated to the stable channel, this will be lifted up. See https://github.com/sony/flutter-embedded-linux/issues/334 for the detailes. Signed-off-by: Hidenori Matsubayashi --- .../platform/linux_embedded/surface/elinux_egl_surface.cc | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/flutter/shell/platform/linux_embedded/surface/elinux_egl_surface.cc b/src/flutter/shell/platform/linux_embedded/surface/elinux_egl_surface.cc index 07fede8..2efe002 100644 --- a/src/flutter/shell/platform/linux_embedded/surface/elinux_egl_surface.cc +++ b/src/flutter/shell/platform/linux_embedded/surface/elinux_egl_surface.cc @@ -168,6 +168,11 @@ void ELinuxEGLSurface::PopulateExistingDamage(const intptr_t fbo_id, 0, 0, static_cast(width_px_), static_cast(height_px_)}; existing_damage->damage = existing_damage_map_[fbo_id]; + // Temporarily disabled partial repaints due to + // https://github.com/sony/flutter-embedded-linux/issues/334. Once + // https://github.com/flutter/engine/pull/45611 was merged and propagated to + // the stable channel, this will be lifted up. +#if 0 if (age > 1) { --age; // join up to (age - 1) last rects from damage history @@ -191,6 +196,7 @@ void ELinuxEGLSurface::PopulateExistingDamage(const intptr_t fbo_id, } } } +#endif } // Auxiliary function used to transform a FlutterRect into the format that is