Fix the location of the C extension #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please merge sot/skare3/pull/329 before this one |
jeanconn
approved these changes
Apr 11, 2020
|
Also, not clear about why skare3's 329 PR needs to go "first"? |
taldcroft
approved these changes
Apr 11, 2020
|
well, one issue with the way the automated builds for ska3-masters are setup now is that they build when you merge to master. If you merge this to master first, it uses the wrong version of skare3 (also master). Actually, in this case it does not matter since all namespace packages will have to be rebuilt. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After the namespace module changes, it turned out the fastss C extension was being installed in site-packages/numpy instead of site-packages/Ska/Numpy. This PR fixes that.
Testing
Fixes #