Move allowed_rolldev here from sparkles and update pitch/roll table

[jeanconn]

Description

Move allowed_rolldev here from sparkles

Also use updated pitch/roll table. The values come from the update file with a restriction to 17deg starting at pitch 125 and shared with MPCWG in March 2022 (MPCWG/MeetingNotes2022x03x24). That file has signed/positive and negative roll ranges but all the magnitudes are the same for each sign for each row, so reduced the table to the unsigned version.

Testing

• Passes unit tests on MacOS
• Functional testing - new simple test added that is hardcoded for the current pitch/roll table.

Pitch / rolldev data

(this includes a point added at pitch 180 defined as 0 deg allowed off-nominal-roll)

Install test

This was successful.

python setup.py install --user
$ cd ~
$ ipython
import Ska.Sun
print(Ska.Sun.__file__)  # version in ~/.local
Ska.Sun.test('-v')  # pass

[taldcroft]

I thought the team had decided to set the start of the FSS restriction at a pitch of 125? This is what is in the file here in Ska.Sun [EDIT] but I have moved this to a slack question.

[jeanconn]

Good point. I probably should have done this as 3 PRs so I'd have kept better track of file versions.

[taldcroft]

I don't follow the 3 PRs remark. This PR seems good, though you'll want to squash down to one commit at the end.

[jeanconn]

For me, it would actually have been 4 PRs. One to move the code here from sparkles. One to update to the expanded roll range data file. One to update to the modified-at-126 file. One to update to the modified-at-125 file. I got confused about which version we had and what we wanted because there was all of this combining-into-on-step process.

[taldcroft]

I think each of the 4 PR's you mentioned are more at the level of single commits. I had no trouble following this and your single PR as a reviewer. In the end the first 3 PR's you suggested would be abandoned since we don't want commits of the wrong/intermediate data files in the repo.

[taldcroft]

Looks good!

[jeanconn]

Thanks for all the help with this one!