Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve setup.py version fetching in all packages as needed #118

Closed
jeanconn opened this issue Mar 5, 2019 · 5 comments
Closed

Improve setup.py version fetching in all packages as needed #118

jeanconn opened this issue Mar 5, 2019 · 5 comments

Comments

@jeanconn
Copy link
Contributor

jeanconn commented Mar 5, 2019

See

#116 (comment)

@jeanconn
Copy link
Contributor Author

jeanconn commented Oct 28, 2019

Regarding putting the helper functions read, and find_version from

https://github.com/pypa/pip/blob/master/setup.py#L14

into testr. Two things:

  1. testr right now is an optional dependence in most of our builds. Do we want to require it?
  2. those routines would need a little customization for a non-local non-global here

And on a different track, would it make just as much sense to use 4. instead of 1. from:
https://packaging.python.org/guides/single-sourcing-package-version/
?

It seems that we could then just customize __version__ to be read/assigned from VERSION.

@taldcroft
Copy link
Member

I'm still bitter that setuptools_scm turned out to be heavier than we'd like, but reviewing sot/cheta#157 it seemed to be in a working state.

Most of the "single-source" ideas including VERSION are not actually single-source given our package build process.

@jeanconn
Copy link
Contributor Author

jeanconn commented Oct 29, 2019

sot/cheta#157 looked to be in a working state, but I saw it didn't get merged and looks to not complete github build tests. Is the latter just due to the dual-package nature at this point?

@jzuhone
Copy link
Collaborator

jzuhone commented Oct 29, 2019

What about versioneer?

https://github.com/warner/python-versioneer

It does require one to install their package in the Python stack, but after you run it on your package to generate the version-handling code, there are no new dependencies.

@taldcroft
Copy link
Member

See sot/sparkles#129

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants