Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A production not-Perl metapackage? #188

Closed
jeanconn opened this issue Aug 15, 2019 · 8 comments
Closed

A production not-Perl metapackage? #188

jeanconn opened this issue Aug 15, 2019 · 8 comments
Labels
Flight Applies to ska3-flight question

Comments

@jeanconn
Copy link
Contributor

After installing acdc on GRETA ska3/flight, I wondered, perhaps there are more packages like this that do not really need to go in ska3-flight but belong in production?

We can think more about this and make a new metapackage if needed (or rename ska3-perl to ska3-production).

@jeanconn jeanconn added Flight Applies to ska3-flight question labels Aug 15, 2019
@taldcroft
Copy link
Member

👍 on renaming ska3-perl to ska3-production.

About acdc, I can see the point there, though acdc does provide processing utilities that could be useful in generic ACA analysis. In particular the different algorithms for combining quadrant readouts into cal images, e.g. one at a time or median filtering. That's the sort of thing I would do standalone.

@jeanconn
Copy link
Contributor Author

jeanconn commented Oct 1, 2020

So maybe we have some more interest in this, though figuring out which packages belong in a new ska3-production package is somewhat not trivial.

I think this would mean on the Perl side, for example, we'd want ska3-perl (or some other name) to have the minimal set for starcheck to work (on Linux and OSX) and ska3-production to have the rest of the Perl stuff plus any isolated packages that are only useful on HEAD.

@taldcroft
Copy link
Member

I would favor an incremental approach that let's us move forward now without getting stuck by non-trivial decisions. In other words get the low-hanging fruit with an initial PR:

  • Add aca_hi_bgd
  • Move acdc from flight to production
  • Any other completely uncontroversial packages.

@jeanconn
Copy link
Contributor Author

jeanconn commented Oct 1, 2020

OK. I just thought even here you'd said there was value in keeping acdc in ska3-flight for the algorithms for combining quadrants.

@taldcroft
Copy link
Member

Yes, my former self had more insight. The point is just to make some kind of progress forward without overthinking it too much. It doesn't matter all that much. Making ska-production is fine, or just tossing another package into ska3-flight will only make it negligibly bigger and that's fine. Your choice.

@javierggt
Copy link
Contributor

Old issue, more than 2 years old. I think this discussion just died out.

In this issue you even agreed to rename ska3-perl to ska3-production. Two years later it has not happened and I do not see it happening yet 😄 I'm sure that can be considered again, but this discussion should be closed.

@jeanconn
Copy link
Contributor Author

Well, we did continue the discussion even up to October. I suppose I don't know if open discussion best live in closed or open issues...

@javierggt
Copy link
Contributor

Feel free to reopen it if it is an ongoing discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Flight Applies to ska3-flight question
Projects
None yet
Development

No branches or pull requests

3 participants