-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unique tag in ska_version #39
Comments
This is of course something I'd like but figured you'd hate. |
For this, for the conda packages do you want to be sensitive to the build version or just the package version (the thing we are explicitly controlling). |
I think just package version is sufficient. |
If we don't care, it is probably easier to use the build versions too. The json that I'm fetching now with "conda list --json" is great to reformat for the ska3- pieces, but it doesn't have any pip installed packages. I'm assuming you want visibility on those? If so, we need to use something else to get a list that includes pip installed packages, either another call to "conda list" or something else. And if we just have the string out of "conda list" it has those build versions in the text that you'd be using to make the new hash, unless you want to parse the conda list output. |
That's annoying, seems like a bug (that pip packages are not included). Just do anything for now, doesn't have to be a perfect solution. E.g. md5 hash of the string output of |
Gotcha. And yeah, I wasn't shooting for perfection but also figured that the current string out of ska_version is fine for the first round of testing (that things sort of work). |
Closed by #48 |
(I thought of this a while back but forgot to mention it).
In addition to the ska3-* package versions, there should also be some kind of tag in the version output that reflects the collective versions of all packages. For instance the first 7 digits of the md5 hash of the output of
conda list
(or something derived from the JSON components).The point is that a test environment may have all the same ska3-* packages but one or more custom-installed packages. This should show up in ska_testr.
The text was updated successfully, but these errors were encountered: