Skip to content

Commit

Permalink
Expand and improve tests
Browse files Browse the repository at this point in the history
  • Loading branch information
@taldcroft
taldcroft committed Sep 22, 2021
1 parent c71443a commit 0a3a7aa
Show file tree
Hide file tree
Showing 2 changed files with 110 additions and 55 deletions.
6 changes: 3 additions & 3 deletions sparkles/find_er_catalog.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -205,9 +205,9 @@ def get_guide_counts(mags, t_ccd):
ref_counts = [0.0, 1.2, 1.0, 0.5, 0.0]
ref_mags1 = [5.3, 5.4] # Not temperature dependent
ref_mags2 = [9.0, 10.0, 10.3] # Temperature dependent
ref_mags_t_ccd = (ref_mags1 +
[snr_mag_for_t_ccd(t_ccd, ref_mag, ref_t_ccd)
for ref_mag in ref_mags2])
ref_mags_t_ccd = (ref_mags1
+ [snr_mag_for_t_ccd(t_ccd, ref_mag, ref_t_ccd)
for ref_mag in ref_mags2])

# Do the interpolation, noting that np.interp will use the end ``counts``
# values for any ``mag`` < ref_mags[0] or > ref_mags[-1].
Expand Down
159 changes: 107 additions & 52 deletions sparkles/tests/test_find_er_catalog.py
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# Licensed under a 3-clause BSD style license - see LICENSE.rst

import warnings
from proseco import get_aca_catalog
from proseco.tests.test_common import mod_std_info
import numpy as np
Expand All @@ -12,79 +13,133 @@


# Known tough field: PKS 0023-26 pointing
att_pks = Quat([0.20668099834, 0.23164729391, 0.002658888173, 0.9505868852])
date_pks = '2021-09-13'
t_ccd = -8.0
att_pks.equatorial

ATT = Quat([0.20668099834, 0.23164729391, 0.002658888173, 0.9505868852])
DATE = '2021-09-13'
T_CCD = -8.0

# Get initial catalog at the PKS 0023-26 attitude. Ignore the penalty limit for
# this work.
kwargs = mod_std_info(att=att_pks, t_ccd=t_ccd, date='2021-09-13', n_guide=8,
KWARGS = mod_std_info(att=ATT, t_ccd=T_CCD, date=DATE, n_guide=8,
n_fid=0, obsid=99999, t_ccd_penalty_limit=999)
aca_pks = get_aca_catalog(**kwargs)
ACA = get_aca_catalog(**KWARGS)
DPITCHES, DYAWS = np.ogrid[-0.01:-3.5:4j, -3.1:3:3j]
SUN_RA, SUN_DEC = Ska.Sun.position(ACA.date)
ATTS = Ska.Sun.apply_sun_pitch_yaw(ACA.att, pitch=DPITCHES, yaw=DYAWS,
sun_ra=SUN_RA, sun_dec=SUN_DEC)


def test_get_candidate_and_filter_stars():
stars = get_candidate_stars(att_pks, t_ccd, date=date_pks)
stars = filter_candidate_stars_on_ccd(att_pks, stars)
stars = get_candidate_stars(ATT, T_CCD, date=DATE)
stars = filter_candidate_stars_on_ccd(ATT, stars)

count_9th, count_10th, count_all = get_guide_counts(
stars['MAG_ACA'][stars['guide_mask']], t_ccd=-10)
count_9th.round(2), count_10th.round(2), count_all.round(2)
stars['MAG_ACA'][stars['guide_mask']], t_ccd=T_CCD)
assert np.isclose(count_9th, 1.00, atol=0.01)
assert np.isclose(count_10th, 1.67, atol=0.01)
assert np.isclose(count_all, 2.25, atol=0.01)


def test_init_quat_from_attitude():
# Basic tests for init_quat_from_attitude
q = init_quat_from_attitude([Quat([0, 1, 2]),
Quat([3, 4, 5])])
print('From 1-d list of Quat')
print(q.equatorial)
# 1-d list of Quat
assert np.allclose(q.equatorial, [[0, 1, 2],
[3, 4, 5]])

# 2-d list of Quat
q = init_quat_from_attitude([[Quat([0, 1, 2]), Quat([3, 4, 5])]])
print('From 2-d list of Quat')
print(q.equatorial)
assert np.allclose(q.equatorial, [[[0, 1, 2],
[3, 4, 5]]])

# 1-d list of equatorial floats
q = init_quat_from_attitude([[0, 1, 2], [3, 4, 5]])
print('From 2-d list of floats')
print(q.equatorial)
assert np.allclose(q.equatorial, [[[0, 1, 2],
[3, 4, 5]]])

# Heterogenous list of floats
q = init_quat_from_attitude([[0, 1, 2], [0, 1, 0, 0]])
print('From heterogenous list of floats')
print(q.equatorial)
assert np.allclose(q.equatorial, [[0, 1, 2],
[180, 0, 180]])


TEST_COLS = ['dpitch', 'dyaw', 'count_9th', 'count_10th', 'count_all',
'count_ok', 'n_critical', 'att']


def test_find_er_catalog_minus_2():
def test_find_er_catalog_minus_2_pitch_bins():
# Try it all for the bad field near PKS 0023-26
dpitches, dyaws = np.ogrid[0:-3.5:5j, -3:3:5j]
sun_ra, sun_dec = Ska.Sun.position(aca_pks.date)
atts = apply_sun_pitch_yaw(aca_pks.att, pitch=dpitches, yaw=dyaws,
sun_ra=sun_ra, sun_dec=sun_dec)

aca_pks.call_args['t_ccd'] = -2.0
acar, att_opts = find_er_catalog(aca_pks, atts, alg='pitch_bins')
print(acar)
att_opts.pprint_all()
print(acar.guides.t_ccd)
print(acar.att.equatorial)

acar, att_opts = find_er_catalog(aca_pks, atts, alg='count_all')
att_opts.pprint_all()
print(acar.guides.t_ccd)
print(acar.att.equatorial)

acar, att_opts = find_er_catalog(aca_pks, atts, alg='input_order')
att_opts.pprint_all()
print(acar.guides.t_ccd)
print(acar.att.equatorial)

aca_pks.call_args['t_ccd'] = -12.0
acar, att_opts = find_er_catalog(aca_pks, atts, alg='pitch_bins')
att_opts.pprint_all()
print(att_opts['acar'][0].messages)

acar, att_opts = find_er_catalog(aca_pks, atts, alg='count_all')
att_opts.pprint_all()

acar, att_opts = find_er_catalog(aca_pks, atts, alg='input_order')
att_opts.pprint_all()
acar, att_opts = find_er_catalog(ACA, ATTS, alg='pitch_bins')
# import pprint; pprint.pprint(att_opts[TEST_COLS].pformat_all(), width=100)
assert acar is att_opts['acar'][8]
assert att_opts[TEST_COLS].pformat_all() == [
'dpitch dyaw count_9th count_10th count_all count_ok n_critical att ',
'------ ----- --------- ---------- --------- -------- ---------- -----------------',
' -0.01 -3.10 4.18 6.00 5.65 True 2 7.67 -25.22 29.3',
' -0.01 -0.05 1.00 1.67 2.25 False -- 6.47 -26.05 26.1',
' -0.01 3.00 2.62 7.92 5.26 False -- 5.21 -26.82 22.8',
' -1.17 -3.10 2.00 9.33 5.92 False -- 8.49 -26.12 29.7',
' -1.17 -0.05 0.00 1.23 0.78 False -- 7.23 -27.00 26.4',
' -1.17 3.00 0.75 6.87 4.03 False -- 5.91 -27.80 23.1',
' -2.34 -3.10 1.89 7.77 5.21 False -- 9.32 -27.02 30.1',
' -2.34 -0.05 2.87 8.52 5.97 False -- 8.01 -27.93 26.8',
' -2.34 3.00 8.53 13.90 12.67 True 0 6.64 -28.78 23.5',
' -3.50 -3.10 2.12 10.01 6.66 False -- 10.16 -27.91 30.4',
' -3.50 -0.05 4.87 9.63 7.50 True -- 8.80 -28.86 27.2',
' -3.50 3.00 3.60 9.93 6.38 True -- 7.37 -29.75 23.8']


def test_find_er_catalog_minus_2_count_all():
acar, att_opts = find_er_catalog(ACA, ATTS, alg='count_all')
# import pprint; pprint.pprint(att_opts[TEST_COLS].pformat_all(), width=100)
assert acar is att_opts['acar'][8]
assert att_opts[TEST_COLS].pformat_all() == [
'dpitch dyaw count_9th count_10th count_all count_ok n_critical att ',
'------ ----- --------- ---------- --------- -------- ---------- -----------------',
' -0.01 -3.10 4.18 6.00 5.65 True -- 7.67 -25.22 29.3',
' -0.01 -0.05 1.00 1.67 2.25 False -- 6.47 -26.05 26.1',
' -0.01 3.00 2.62 7.92 5.26 False -- 5.21 -26.82 22.8',
' -1.17 -3.10 2.00 9.33 5.92 False -- 8.49 -26.12 29.7',
' -1.17 -0.05 0.00 1.23 0.78 False -- 7.23 -27.00 26.4',
' -1.17 3.00 0.75 6.87 4.03 False -- 5.91 -27.80 23.1',
' -2.34 -3.10 1.89 7.77 5.21 False -- 9.32 -27.02 30.1',
' -2.34 -0.05 2.87 8.52 5.97 False -- 8.01 -27.93 26.8',
' -2.34 3.00 8.53 13.90 12.67 True 0 6.64 -28.78 23.5',
' -3.50 -3.10 2.12 10.01 6.66 False -- 10.16 -27.91 30.4',
' -3.50 -0.05 4.87 9.63 7.50 True -- 8.80 -28.86 27.2',
' -3.50 3.00 3.60 9.93 6.38 True -- 7.37 -29.75 23.8']


def test_find_er_catalog_minus_2_input_order():
acar, att_opts = find_er_catalog(ACA, ATTS, alg='input_order')
# import pprint; pprint.pprint(att_opts[TEST_COLS].pformat_all(), width=100)
assert acar is att_opts['acar'][8]
assert att_opts[TEST_COLS].pformat_all() == [
'dpitch dyaw count_9th count_10th count_all count_ok n_critical att ',
'------ ----- --------- ---------- --------- -------- ---------- -----------------',
' -0.01 -3.10 4.18 6.00 5.65 True 2 7.67 -25.22 29.3',
' -0.01 -0.05 1.00 1.67 2.25 False -- 6.47 -26.05 26.1',
' -0.01 3.00 2.62 7.92 5.26 False -- 5.21 -26.82 22.8',
' -1.17 -3.10 2.00 9.33 5.92 False -- 8.49 -26.12 29.7',
' -1.17 -0.05 0.00 1.23 0.78 False -- 7.23 -27.00 26.4',
' -1.17 3.00 0.75 6.87 4.03 False -- 5.91 -27.80 23.1',
' -2.34 -3.10 1.89 7.77 5.21 False -- 9.32 -27.02 30.1',
' -2.34 -0.05 2.87 8.52 5.97 False -- 8.01 -27.93 26.8',
' -2.34 3.00 8.53 13.90 12.67 True 0 6.64 -28.78 23.5',
' -3.50 -3.10 2.12 10.01 6.66 False -- 10.16 -27.91 30.4',
' -3.50 -0.05 4.87 9.63 7.50 True -- 8.80 -28.86 27.2',
' -3.50 3.00 3.60 9.93 6.38 True -- 7.37 -29.75 23.8']


def test_find_er_catalog_fails():
"""Test a catalog that will certainly fail at +10 degC"""
kwargs = mod_std_info(att=ATT, t_ccd=+10, date=DATE, n_guide=8,
n_fid=0, obsid=99999, t_ccd_penalty_limit=999)

with warnings.catch_warnings():
# Ignore warning about grid_model clipping t_ccd
warnings.filterwarnings("ignore", module=r'.*star_probs.*')
aca = get_aca_catalog(**kwargs)
acar, att_opts = find_er_catalog(aca, ATTS, alg='input_order')
assert acar is None
assert not np.any(att_opts['count_ok'])

0 comments on commit 0a3a7aa

Please sign in to comment.