You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It looks like sparkles will throw an unhandled exception on P2 for a one-star catalog
661
662 # Probability of 2 or fewer stars => conservative fail criteria
--> 663 p2 = p_n_cum[2]
664
665 if verbose:
IndexError: index 2 is out of bounds for axis 0 with size 2
and the geometry check fails if we don't have more than 2 guide stars
774min_dist=500775min_dist2=min_dist**2-->776foridxsincombinations(guide_idxs, n_guide-2):
777foridx0, idx1incombinations(idxs, 2):
778# If any distance in this combination exceeds min_dist thenValueError: rmustbenon-negative
These are basically fine to not handle in operational use with ORViewer (if the catalogs are that bad, an error and no catalog is probably fine) but I think we should just throw appropriate critical warnings and complete the review in these cases.
I can also try to handle these specific errors in yoshi (where this is coming up) but that seems the wrong place.
The text was updated successfully, but these errors were encountered:
It looks like sparkles will throw an unhandled exception on P2 for a one-star catalog
and the geometry check fails if we don't have more than 2 guide stars
These are basically fine to not handle in operational use with ORViewer (if the catalogs are that bad, an error and no catalog is probably fine) but I think we should just throw appropriate critical warnings and complete the review in these cases.
I can also try to handle these specific errors in yoshi (where this is coming up) but that seems the wrong place.
The text was updated successfully, but these errors were encountered: