Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply effective temperature "penalty" #308

Closed
jeanconn opened this issue Jun 5, 2019 · 4 comments
Closed

Apply effective temperature "penalty" #308

jeanconn opened this issue Jun 5, 2019 · 4 comments

Comments

@jeanconn
Copy link
Contributor

jeanconn commented Jun 5, 2019

Since the starcheck calls to the proseco stuff are constructing an acq catalog from the commanded catalog and then getting calc_p_safe, I think the the proseco get_effective_t_ccd method is never called.

We probably want to use the penalty on the starcheck side too (for the time being, until sparkles checks are properly integrated).

@taldcroft
Copy link
Member

taldcroft commented Jun 7, 2019

I think this should be fairly trivial, namely just replace the call to get_acq_catalog to get_aca_catalog, with a few tweaks to the kwargs. The use aca.acqs instead of acq_cat.

Probably just need to add n_guide=0, n_fid=0. You don't have to change the include_* kwargs, but it might make the code more clear to use include_ids_acq (etc).

Going through the cat_aca_catalog function will engage the effective temperature machinery.

@taldcroft
Copy link
Member

Which points to a general API recommendation of always using get_aca_catalog for making catalogs, even if only an acq catalog is desired.

@jeanconn
Copy link
Contributor Author

jeanconn commented Jun 7, 2019

Right, I think we had a bunch of proseco API changes after I figured out something for starcheck and I wasn't sure if this transition was worth it until we had include_ids_fids.

@jeanconn jeanconn changed the title Apply effective temperature "penalty" in acq catalog review Apply effective temperature "penalty" Jun 7, 2019
@jeanconn
Copy link
Contributor Author

Closed by #309

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants