-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply effective temperature "penalty" #308
Comments
I think this should be fairly trivial, namely just replace the call to Probably just need to add Going through the |
Which points to a general API recommendation of always using |
Right, I think we had a bunch of proseco API changes after I figured out something for starcheck and I wasn't sure if this transition was worth it until we had |
Closed by #309 |
Since the starcheck calls to the proseco stuff are constructing an acq catalog from the commanded catalog and then getting calc_p_safe, I think the the proseco get_effective_t_ccd method is never called.
We probably want to use the penalty on the starcheck side too (for the time being, until sparkles checks are properly integrated).
The text was updated successfully, but these errors were encountered: