Skip to content
This repository has been archived by the owner on Dec 5, 2024. It is now read-only.

allow React 16 as a peerDependency #59

Merged
merged 1 commit into from
Oct 21, 2017
Merged

Conversation

okize
Copy link
Contributor

@okize okize commented Oct 2, 2017

This will allow consumers to use react-popper with React 16.

I didn't update the devDependency version of React 16 in this PR, although I did in my fork and everything appeared to work correctly.

@gnapse
Copy link
Contributor

gnapse commented Oct 11, 2017

This would be nice to have. I use material-ui which uses react-popper, and everything works fine under react 16. I just get this unmet peer dependency warning when running yarn in the terminal.

@souporserious
Copy link
Collaborator

Sorry for the wait on this, I've been extremely busy as of late. I really appreciate the PR! Thank you ❤️

@souporserious souporserious merged commit 212a421 into floating-ui:master Oct 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants