-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade gl to v8 #1630
Open
RichDom2185
wants to merge
19
commits into
master
Choose a base branch
from
gl-8-upgrade
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Upgrade gl to v8 #1630
+10,723
−7,318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@sayomaki we need to figure out how to resolve the require on ESM error&hellip... it's blocking our gl migration for both frontend and js-slang :( Should we just use Yarn 3? |
…nto gl-8-upgrade
@sayomaki I think best to just use latest Yarn. Doesn't hurt anyway. |
Pull Request Test Coverage Report for Build 10403964584Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refer to their release notes.
Now, we have prebuilt binaries shipped for most systems, so it will save us so much time (and compute resources – especially for GitHub Actions runners) to not have to build from source each time.
Beyond that, they also add GCC 13 support. Closes #1417. Will also close #1508 as unplanned (as the root cause is fixed – no more motivation to necessarily move out).
Also updates to latest Yarn and bumps Prettier