Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

potential next steps for the sourmash sketch command #1169

Open
ctb opened this issue Aug 14, 2020 · 2 comments
Open

potential next steps for the sourmash sketch command #1169

ctb opened this issue Aug 14, 2020 · 2 comments

Comments

@ctb
Copy link
Contributor

ctb commented Aug 14, 2020

#1159 adds sourmash sketch dna|protein|translate. This issue tracks some potential additions to that --

  • we could provide additional subcommands, like sourmash sketch reads, sourmash sketch genome, and sourmash sketch ncbi, that choose good defaults for those kinds of inputs
    • e.g. for reads, scaled=1000,abund
  • we are removing 10x support so no need to add anything there.
  • similarly, we could alias sourmash sketch dayhoff and sourmash sketch hp.
  • could add sourmash sketch 16s (see e.g. classification with full length 16S gene #1000)

Additional thoughts:

  • @luizirber proposed a passthrough option, where you could chain the inputs together:
    • sourmash sketch dna --passthrough <input> | sourmash sketch protein <input> - this would yield two signatures. Not sure how to do the output tho - where does the signature file go? do we need to specify multiple different -o options?!
  • translate should take options to specify top-strand/rc only, for RNA.
  • can we make the sketch module suitable for direct use by Python, per Idea: imports match CLI? #1112?
    • e.g. sourmash.sketch.dna(filenames=...)
  • the sketch module should auto-recognize signature files and not try to load them as FASTA... sourmash compute doesn't recognize signature files #814
  • might be good to add automated traverse functionality to discover all FASTA files, if possible, at least for specific commands...
@ctb
Copy link
Contributor Author

ctb commented Aug 14, 2020

I think maybe the stuff in my comment here #999 (comment) around detecting/flagging bad inputs should be examined for sourmash sketch to see if we've resolved that UX disaster...

@ctb ctb changed the title potential next steps for sourmash sketch potential next steps for the sourmash sketch command Mar 4, 2021
@ctb
Copy link
Contributor Author

ctb commented Mar 4, 2021

maybe add name to param strings per #1315

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant