You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
we should make sure that the top-level APIs for search and Index are using SourmashSignature and not MinHash objects. That protects us from specific details of the sketch, and potentially lets us make use of fine tuned, or more advanced, or just plain different sketch types.
Right now most of the top-level APIs do use query rather than query_mh, but the peek and consume methods and the make_gather_query function take MinHash directly, and peek returns a MinHash as well.
in re #1370,
we should make sure that the top-level APIs for search and Index are using
SourmashSignature
and notMinHash
objects. That protects us from specific details of the sketch, and potentially lets us make use of fine tuned, or more advanced, or just plain different sketch types.Right now most of the top-level APIs do use
query
rather thanquery_mh
, but thepeek
andconsume
methods and themake_gather_query
function take MinHash directly, andpeek
returns aMinHash
as well.ref #616
The text was updated successfully, but these errors were encountered: