Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SourmashSignature for top-level search and Index APIs. #1514

Open
ctb opened this issue May 10, 2021 · 0 comments
Open

Use SourmashSignature for top-level search and Index APIs. #1514

ctb opened this issue May 10, 2021 · 0 comments

Comments

@ctb
Copy link
Contributor

ctb commented May 10, 2021

in re #1370,

we should make sure that the top-level APIs for search and Index are using SourmashSignature and not MinHash objects. That protects us from specific details of the sketch, and potentially lets us make use of fine tuned, or more advanced, or just plain different sketch types.

Right now most of the top-level APIs do use query rather than query_mh, but the peek and consume methods and the make_gather_query function take MinHash directly, and peek returns a MinHash as well.

ref #616

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant