fix: CVE-2020-8203 with lodash.pick #431
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andres-robinet-sw
changed the title
Pull Request Test Coverage Report for Build 9617025766Details
💛 - Coveralls |
andres-robinet-sw
changed the title
JhontSouth
approved these changes
Jun 24, 2024
sw-joelmut
requested changes
Jun 25, 2024
andres-robinet-sw
force-pushed
the
southworks/update/fix/lodash-pick-vulnerability
branch
from
9246fc7 to
f4cb2b0
Compare
Pull Request Test Coverage Report for Build 9665734501Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9665734501Details
💛 - Coveralls |
sw-joelmut
approved these changes
Jun 25, 2024
andres-robinet-sw
force-pushed
the
southworks/update/fix/lodash-pick-vulnerability
branch
from
f4cb2b0 to
b59706e
Compare
Pull Request Test Coverage Report for Build 9666869462Details
💛 - Coveralls |
|
/promoted 4692 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses # 4684
#minor
Description
This PR updates the version of lodash.pick and fixes the CVE-2020-8203 vulnerability.
There is no patch for lodash.pick@4.4.0 which is a dependency of nightwatch@2.6.21.
Per Method Packages are discouraged by lodash and nightwatch@3.4.0 fixes this.
However, there's a transitive dependency with jsdom@23.1.0 which restricts Node engines to
>=18.Thus, we need to force a fully patched version of lodash to replace lodash.pick.
Specific Changes
Testing
The following screenshot shows the updated version for the lodash.pick package.
