Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Default Custom Method. #739

Closed
ip312 opened this issue Apr 23, 2024 · 5 comments · Fixed by #856 or #859
Closed

No Default Custom Method. #739

ip312 opened this issue Apr 23, 2024 · 5 comments · Fixed by #856 or #859
Assignees
Labels
component/edc-ui affected software component kind/enhancement New feature or request

Comments

@ip312
Copy link

ip312 commented Apr 23, 2024

Description - What happened? *

In the paramerization section on the consumer side the Custom Method is currenty not set. The field is just empty.
grafik

Expected Behavior *

GET method as default.

Observed Behavior *

If a user forgets to select a method, the connector will be stuck in requesting status forever.
To minimize possible errors, it is best to set a default value.

Steps to Reproduce

No response

Context Information

No response

Relevant log output

No response

Screenshots

No response

@ip312 ip312 added the kind/bug Something isn't working. The software does not behave as expected or specified. label Apr 23, 2024
@tmberthold
Copy link
Member

Hello and Thank You for reaching out to us!
Since this is about the UI, I will move this issue accordingly to the ui-repo.
I'll forward it internally and our team will let you know when there's any news.

@tmberthold tmberthold transferred this issue from sovity/edc-ce Apr 23, 2024
@jkbquabeck
Copy link
Collaborator

Hello @ip312, we changed this presetting to clearly indicate that a user needs to take action to use the parameterization. This This change was necessary since the UI displayed GET before but did not actually select GET as the preset method.

@tmberthold tmberthold added kind/enhancement New feature or request kind/question Further information is requested task/ui-ux Requires UI/UX input. Create a Mock-up / Low Fidelity Prototype. and removed kind/bug Something isn't working. The software does not behave as expected or specified. labels Apr 26, 2024
@AbdullahMuk AbdullahMuk added the clean-backlog requires backlog cleaning label May 2, 2024
@SebastianOpriel
Copy link
Member

Feature itself is no bug, but leads to a bug when no method is chosen, then Connector might lead to an error state.

@AbdullahMuk AbdullahMuk added the component/edc-ui affected software component label Sep 2, 2024
@AbdullahMuk AbdullahMuk removed task/ui-ux Requires UI/UX input. Create a Mock-up / Low Fidelity Prototype. clean-backlog requires backlog cleaning labels Sep 16, 2024
@AbdullahMuk AbdullahMuk assigned illfixit and unassigned jkbquabeck Sep 16, 2024
@AbdullahMuk
Copy link
Collaborator

@illfixit proposal to improve this situation: make the first option in the dropdown list as default

Image

@SebastianOpriel
Copy link
Member

There was a good reason not to preset GET. Instead please simply make the field mandatory to choose.

@SebastianOpriel SebastianOpriel removed the kind/question Further information is requested label Sep 27, 2024
@illfixit illfixit linked a pull request Sep 29, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/edc-ui affected software component kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants