Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the app thread safe #6

Closed
soynatan opened this issue Feb 20, 2017 · 3 comments
Closed

Make the app thread safe #6

soynatan opened this issue Feb 20, 2017 · 3 comments

Comments

@soynatan
Copy link
Owner

From u/boxidea in r/django:

I don't think that storing the request on the EasyAuditMiddleware class is a good idea.

Middleware classes are shared across requests, so anything you store on the class is not going to be thread safe.

https://www.reddit.com/r/django/comments/5ux246/hello_everyone_i_created_a_simple_django_app_to/ddxpw8n/

@jheld
Copy link
Collaborator

jheld commented Mar 1, 2017

@soynatan any update on this?

@soynatan
Copy link
Owner Author

soynatan commented Mar 1, 2017

No, I haven't had any time to check this. I opened the issue so I wouldn't forget about it. If you want to try this fix go ahead, otherwise I'll do it in a couple of days.

@soynatan
Copy link
Owner Author

soynatan commented Mar 5, 2017

I applied the fix. Seems to be working ok. We'll open another issue if it causes any problem.

@soynatan soynatan closed this as completed Mar 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants