Skip to content
This repository has been archived by the owner on Apr 23, 2021. It is now read-only.

awesimsoss time-stamps give the end of the frame-reads and not the middle #76

Closed
nespinoza opened this issue Jun 23, 2020 · 1 comment
Closed

Comments

@nespinoza
Copy link
Collaborator

nespinoza commented Jun 23, 2020

The time stamps returned by awesimsoss are the ones at the end of each frame-read. However, the code should return time-stamps which are at the middle of each frame-read (in theory it should be the time weighted by the flux during a frame-read, but this is not possible to measure).

The middle time-stamps are, I believe, the most representative time for a given frame-read. The easiest way to see this is in the limiting case in which you only have two out-of-transit baseline points and one point taken exactly in-transit. Imagine a transit lasts a frame-time; then, I believe it makes sense for the in-transit point to have the middle of the time spent reading the data and not the time stamp at the end of the frame-time in order for that dataset to make sense.

This is also important for users that want to sample "real" transit lightcurves accounting for, e.g., the finite frame-read times which would smear out the transit lightcurves at the end. It is assumed in these supersampling schemes (see, e.g., https://arxiv.org/abs/1004.3741) that the time-stamps are in the middle of the read. batman also assumes the same to perform supersampling (https://www.cfa.harvard.edu/~lkreidberg/batman/tutorial.html#supersampling).

@nespinoza nespinoza changed the title Transit lightcurves are not supersampled in order to account for finite exposure times awesimsoss time-stamps give the end of the frame-reads and not the middle time-stamps Jun 23, 2020
@nespinoza nespinoza changed the title awesimsoss time-stamps give the end of the frame-reads and not the middle time-stamps awesimsoss time-stamps give the end of the frame-reads and not the middle Jun 23, 2020
nespinoza added a commit to nespinoza/awesimsoss that referenced this issue Jun 23, 2020
… of frame-reads. Changed header values accordingly.
@hover2pi
Copy link
Collaborator

Fixed in #73

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants