Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore removing update_or_keep/2 from Spandex.Span #65

Open
zachdaniel opened this issue Aug 26, 2018 · 0 comments
Open

Explore removing update_or_keep/2 from Spandex.Span #65

zachdaniel opened this issue Aug 26, 2018 · 0 comments

Comments

@zachdaniel
Copy link
Member

Right now, a lot of errors are ignored via usage of update_or_keep/2, which either updates the span and returns the new span, or doesn't update the span at all but returns the old span. This made some sense as a way to have consistent return types, but we're moving towards having more idiomatic return types, and that includes not swallowing errors. More discussion can be found in #63, where the issue was originally discovered. Additionally, that PR adds tests that can be un-skipped when the update functions have these new predictable return types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant