Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add enabled config option and deprecate disabled? option #94

Open
GregMefford opened this issue Dec 4, 2018 · 1 comment
Open

add enabled config option and deprecate disabled? option #94

GregMefford opened this issue Dec 4, 2018 · 1 comment

Comments

@GregMefford
Copy link
Member

I think it's kind of confusing to have negative configuration options like disabled?: true rather than enabled: false. I also think it looks weird to have configuration options with question marks at the end, but I might be the one who's wrong on that one. It bothers me less when it's a function name.

I think we could make this change without breaking anything, so it doesn't need to wait for the 3.0.0 milestone.

@zachdaniel
Copy link
Member

This should be a relatively easy change to add, we'll just have to respect both flags for a period of time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants