Fixed unset wiced_result for tcp clients on socket_send #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the heads up about this oversight. 👍 I changed the return type of tcp_server_client_t::write so that we avoid the cast. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that on the Photon platform, TCPClient::write does ALWAYS return -7009 if it is a client connection of a TCPServer. Looking at the code, I see that the socket return code is written to the wrong variable, result instead of wiced_result. This is leads to a constant return value of WICED_TCPIP_INVALID_SOCKET (7009) which subsequently gets negated.
Casting the int return code to wiced_result_t and assigning it to wiced_result is the fix.