Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wifi connect timeout #898

Merged
merged 2 commits into from
Mar 18, 2016
Merged

wifi connect timeout #898

merged 2 commits into from
Mar 18, 2016

Conversation

m-mcgowan
Copy link
Contributor

adds a 60 second timeout to wlan_connect() to attempt to regain control after a runaway wifi connect

@m-mcgowan m-mcgowan added this to the 0.5.x milestone Mar 10, 2016
…attempt to regain control after a runaway wifi connect
@m-mcgowan m-mcgowan force-pushed the feature/photon/connect_timeout branch from 1d202e9 to fed1289 Compare March 10, 2016 08:36
@m-mcgowan
Copy link
Contributor Author

@monkbroc Please review. I have not been able to test the case when wifi takes longer than 60 seconds to connect, but we do know that the wlan_cancel_connect() call is good - we can emulate the same by pressing the setup button for 3s while wifi is connecting.

monkbroc added a commit that referenced this pull request Mar 18, 2016
@monkbroc monkbroc merged commit f24b7c1 into develop Mar 18, 2016
@monkbroc monkbroc deleted the feature/photon/connect_timeout branch March 23, 2016 00:26
@markterrill
Copy link

Does this mean it will go to listening mode?

I'd previously setup an ISR timer to alternate (poorly) between listen and connect mode and timeout if either hadn't succeeded within a given timeframe. IE like https://community.particle.io/t/listen-network-wont-shut-down-in-semi-automatic/18449/3

I suppose the question is whether either connecting or listening mode will still stick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants