feature/dfu_device_id #949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests:
Results: |
| @@ -75,8 +75,8 @@ typedef struct __attribute__((packed)) application_dct { | |||
| uint8_t alt_device_private_key[192]; // alternative device private key | |||
| uint8_t alt_server_public_key[192]; | |||
| uint8_t alt_server_address[DCT_SERVER_ADDRESS_SIZE]; // server address info | |||
|
|
|||
| uint8_t reserved2[640]; | |||
| uint8_t device_id[12]; // the STM32 device ID | |||
There was a problem hiding this comment.
Wouldn't it be more accurate to say "the Particle device ID"? It's not an STM code, right?
There was a problem hiding this comment.
They are actually the same. We use standard STM32 Unique device ID register (96 bits).
There was a problem hiding this comment.
I added "Device electronic signature" in a comment in the appropriate HAL function since that's the STM name for the unique device ID.
|
Reviewed. Good to merge. |
m-mcgowan
force-pushed
the
feature/dfu_device_id
branch
from
55f8460 to
eed95ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the device ID available via dfu, via the DCT, offset 3618, length 12.
The device ID is copied to persistent storage if the first byte is not 0xFF.
Works on the P1/Photon/Electron.
Core TBD.
The DCT contained a field "device_id" which stored a 6 digit random code. This was renamed "device_code", so we can use "device_id" for the 12 byte stm32 id.
Doneness: