Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delegate callback when user makes choice to install / dismiss / skip an update #2250

Closed
zorgiepoo opened this issue Aug 31, 2022 · 0 comments · Fixed by #2257
Closed
Milestone

Comments

@zorgiepoo
Copy link
Member

zorgiepoo commented Aug 31, 2022

We already have one for skipping:

- (void)updater:(SPUUpdater *)updater userDidSkipThisVersion:(SUAppcastItem *)item;

Might as well add one for dismissing. Also we should pass the user update state, potentially deprecate this skip one (for a newer one with user update state), and use "update" instead of "thisVersion" ..

edit: actually, I need to give this more thought.. since this isn't when the update cycle ends, but maybe that is when the delegate actually cares.

@zorgiepoo zorgiepoo added this to the 2.3 milestone Aug 31, 2022
@zorgiepoo zorgiepoo changed the title Add delegate callback for dismissing update Add delegate callback when user makes choice to install / dismiss / skip an update Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant