Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): send "name", "path" to API #317

Merged
merged 1 commit into from
Apr 14, 2020
Merged

Conversation

kunyan
Copy link
Contributor

@kunyan kunyan commented Apr 14, 2020

Closes / Fixes / Resolves

Fix #316

Explain the feature/fix

Does this PR introduce a breaking change

Screenshot(s)

View Screenshots

Ready-for-merge Checklist

  • Expected files: all files in this pull request are related to one feature request or issue (no stragglers)?
  • Does the change have appropriate unit tests?
  • Did tests pass?
  • Did you update or add any necessary documentation (README.md, WHY.md, etc.)?
  • Was this feature demo'd and the design review approved?

@codecov-io
Copy link

codecov-io commented Apr 14, 2020

Codecov Report

Merging #317 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #317   +/-   ##
=======================================
  Coverage   71.62%   71.62%           
=======================================
  Files          23       23           
  Lines         370      370           
  Branches       23       23           
=======================================
  Hits          265      265           
  Misses         98       98           
  Partials        7        7           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0030706...ef078d7. Read the comment docs.

@kunyan kunyan added cli SPAship command-line interface bug Something isn't working labels Apr 14, 2020
@sayak-sarkar sayak-sarkar merged commit 412e145 into master Apr 14, 2020
@sayak-sarkar sayak-sarkar deleted the cli-more-params branch April 14, 2020 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cli SPAship command-line interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: CLI not send "name" and "path" to API, they are api required
3 participants