From b08f50bb85e12566d85ed9c3a98a1a9f25fca117 Mon Sep 17 00:00:00 2001 From: Valentyn Nykoliuk Date: Wed, 5 Feb 2020 16:09:30 +0000 Subject: [PATCH 1/3] Correctly report errors when cloud deployment fails to launch --- .../DeploymentLauncher/DeploymentLauncher.cs | 1 + .../Private/SpatialGDKEditorCloudLauncher.cpp | 8 ++++++++ 2 files changed, 9 insertions(+) diff --git a/SpatialGDK/Build/Programs/Improbable.Unreal.Scripts/DeploymentLauncher/DeploymentLauncher.cs b/SpatialGDK/Build/Programs/Improbable.Unreal.Scripts/DeploymentLauncher/DeploymentLauncher.cs index 2f977527cc..93864ec6e0 100644 --- a/SpatialGDK/Build/Programs/Improbable.Unreal.Scripts/DeploymentLauncher/DeploymentLauncher.cs +++ b/SpatialGDK/Build/Programs/Improbable.Unreal.Scripts/DeploymentLauncher/DeploymentLauncher.cs @@ -189,6 +189,7 @@ private static int CreateDeployment(string[] args) { Console.WriteLine( $"Unable to launch the deployment(s). This is likely because the project '{projectName}' or assembly '{assemblyName}' doesn't exist."); + return 1; } else { diff --git a/SpatialGDK/Source/SpatialGDKEditor/Private/SpatialGDKEditorCloudLauncher.cpp b/SpatialGDK/Source/SpatialGDKEditor/Private/SpatialGDKEditorCloudLauncher.cpp index a147fce9c6..8de15eb7d1 100644 --- a/SpatialGDK/Source/SpatialGDKEditor/Private/SpatialGDKEditorCloudLauncher.cpp +++ b/SpatialGDK/Source/SpatialGDKEditor/Private/SpatialGDKEditorCloudLauncher.cpp @@ -48,6 +48,10 @@ bool SpatialGDKCloudLaunch() if (OutCode != 0) { UE_LOG(LogSpatialGDKEditorCloudLauncher, Error, TEXT("Cloud Launch failed with code %d: %s"), OutCode, *OutString); + if (!OutErr.IsEmpty()) + { + UE_LOG(LogSpatialGDKEditorCloudLauncher, Error, TEXT("%s"), *OutErr); + } bSuccess = false; } @@ -76,6 +80,10 @@ bool SpatialGDKCloudStop() if (OutCode != 0) { UE_LOG(LogSpatialGDKEditorCloudLauncher, Error, TEXT("Cloud Launch failed with code %d: %s"), OutCode, *OutString); + if (!OutErr.IsEmpty()) + { + UE_LOG(LogSpatialGDKEditorCloudLauncher, Error, TEXT("%s"), *OutErr); + } bSuccess = false; } From f051ee62dae766983ceda63bbaa3efcaec96129a Mon Sep 17 00:00:00 2001 From: Valentyn Nykoliuk Date: Wed, 5 Feb 2020 16:14:04 +0000 Subject: [PATCH 2/3] Add release note --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index f234ff8508..faae1896c6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -20,6 +20,7 @@ Features listed in the internal section are not ready to use but, in the spirit ### Bug fixes: - Replicated references to newly created dynamic subobjects will now be resolved correctly. +- Cloud deployment flow will now correctly report errors when a deployment fails to launch. ## [`0.8.0-preview`] - 2019-12-17 From 0646e2c5cec25b93b81936a36f6b6adfcd8d1e42 Mon Sep 17 00:00:00 2001 From: improbable-valentyn <32096431+improbable-valentyn@users.noreply.github.com> Date: Wed, 5 Feb 2020 16:25:45 +0000 Subject: [PATCH 3/3] Apply suggestions from code review --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index faae1896c6..54c8867c4a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -20,7 +20,7 @@ Features listed in the internal section are not ready to use but, in the spirit ### Bug fixes: - Replicated references to newly created dynamic subobjects will now be resolved correctly. -- Cloud deployment flow will now correctly report errors when a deployment fails to launch. +- Cloud deployment flow will now correctly report errors when a deployment fails to launch due to a missing assembly. ## [`0.8.0-preview`] - 2019-12-17