filterCurrent on TenantCollection

[chris-ware]

Would adding a filterCurrent method onto TenantCollection be something you'd consider? I'd be happy to take a look at adding a PR for this, looks like most of the mechanics are already there for it in TenantCollection itself. I'd maybe struggle a bit with the test case, but I'm sure it could be tweaked before merging if needed, unless the awesome team at Spatie want to do this yourselves.

[masterix21]

Hi @chris-ware, could you explain better the feature suggested? Can’t you use a filter by id?

[freekmurze]

If the code is simple and well tested, I’d accept a PR that adds that to the package.

[chris-ware]

@freekmurze I think I can do that easily following along the same code patterns as the eachCurrent and mapCurrent methods. I'll have a go and send a PR in once I'm done.

[masterix21]

@freekmurze, isn't better to use the __call magic method to handle all methods using the prefix Current? It will solve any further implementation.

[freekmurze]

I'm thinking that with __call we'll lose autocompletion in IDE's. Let's add this filterCurrent now. If any other methods get requests we could opt to refactor them all to __call

[chris-ware]

I agree, I also think only some methods would need a Current variant in the tenant collection. I would exect that was the intention anyway with the TenantCollection. It also means that if new methods are added to the base Laravel Collection, it wouldn't need testing and new version constraints to ensure it works.