Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LicenseCompareHelper: GPL-2.0 license text not recognised #217

Closed
sdheh opened this issue Nov 24, 2023 · 2 comments
Closed

LicenseCompareHelper: GPL-2.0 license text not recognised #217

sdheh opened this issue Nov 24, 2023 · 2 comments

Comments

@sdheh
Copy link

sdheh commented Nov 24, 2023

License text: https://www.gnu.org/licenses/old-licenses/gpl-2.0.txt
Emoji represent whether this result is expected or not.

Results:
matchingStandardLicenseIdsWithinText -> empty list ❌
matchingStandardLicenseIds -> empty list ❌
isTextStandardLicense with GPL-2.0, GPL-2.0-only or GPL-2.0-or-later -> Additional text found after the end of the expected license text starting at line #280 column #21 "end" ❌

Results when excluding optional end (keep lines 1-278):
matchingStandardLicenseIdsWithinText -> empty list ❌
matchingStandardLicenseIds -> GPL-2.0, GPL-2.0-only or GPL-2.0-or-later ✅
isTextStandardLicense with GPL-2.0, GPL-2.0-only or GPL-2.0-or-later -> No difference found ✅

I also checked the difference between the optional text in the end of the GPL-2.0 license xml template and the license text using a diff tool and didn't find any difference.

Note: tested using version 1.1.8

@goneall
Copy link
Member

goneall commented Dec 6, 2023

I suspect this is also related to the pattern .{0,36000} failing as documented in #214 Once we have a fix for that, I'll test to see if this is resolved.

@goneall
Copy link
Member

goneall commented Dec 13, 2023

Fixed with PR #221

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants