diff --git a/src/main/java/org/spdx/library/model/SpdxFile.java b/src/main/java/org/spdx/library/model/SpdxFile.java index 8b3ac52e..0d3bc52b 100644 --- a/src/main/java/org/spdx/library/model/SpdxFile.java +++ b/src/main/java/org/spdx/library/model/SpdxFile.java @@ -89,7 +89,6 @@ protected SpdxFile(SpdxFileBuilder spdxFileBuilder) throws InvalidSPDXAnalysisEx setName(spdxFileBuilder.name); setLicenseConcluded(spdxFileBuilder.concludedLicense); addChecksum(spdxFileBuilder.sha1); - getLicenseInfoFromFiles().addAll(spdxFileBuilder.licenseInfosFromFile); // optional parameters - SpdxElement getAnnotations().addAll(spdxFileBuilder.annotations); @@ -99,7 +98,9 @@ protected SpdxFile(SpdxFileBuilder spdxFileBuilder) throws InvalidSPDXAnalysisEx // optional parameters - SpdxItem setLicenseComments(spdxFileBuilder.licenseComments); getAttributionText().addAll(spdxFileBuilder.attributionText); - + if (Objects.nonNull(spdxFileBuilder.licenseInfosFromFile)) { + getLicenseInfoFromFiles().addAll(spdxFileBuilder.licenseInfosFromFile); + } // optional parameters - SpdxFile Iterator iter = spdxFileBuilder.checksums.iterator(); while (iter.hasNext()) { @@ -328,7 +329,6 @@ public static class SpdxFileBuilder { // required fields - SpdxItem AnyLicenseInfo concludedLicense; - Collection licenseInfosFromFile; String copyrightText; // required fields - SpdxFile @@ -342,6 +342,7 @@ public static class SpdxFileBuilder { // optional fields - SpdxItem String licenseComments = null; Collection attributionText = new ArrayList(); + Collection licenseInfosFromFile; // optional fields - SpdxFile Collection checksums = new ArrayList(); @@ -363,13 +364,13 @@ public static class SpdxFileBuilder { */ public SpdxFileBuilder(IModelStore modelStore, String documentUri, String id, @Nullable ModelCopyManager copyManager, String name, - AnyLicenseInfo concludedLicense, Collection licenseInfosFromFile, + AnyLicenseInfo concludedLicense, + @Nullable Collection licenseInfosFromFile, String copyrightText, Checksum sha1) { Objects.requireNonNull(modelStore, "Model store can not be null"); Objects.requireNonNull(documentUri, "Document URI can not be null"); Objects.requireNonNull(id, "ID can not be null"); Objects.requireNonNull(name, "Name can not be null"); - Objects.requireNonNull(licenseInfosFromFile, "License info from files can not be null"); Objects.requireNonNull(sha1, "SHA1 can not be null"); this.modelStore = modelStore; this.documentUri = documentUri;