Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cardinality constraints on external properties of AIPackage and DatasetPackage should be used consistently #702

Closed
sbarnum opened this issue Apr 8, 2024 · 2 comments
Labels
Profile:AI Artificial intelligence profile Profile:Dataset
Milestone

Comments

@sbarnum
Copy link
Collaborator

sbarnum commented Apr 8, 2024

The markdown file for AIPackage defines the following property constraints:

  • /Core/Artifact/suppliedBy
    • minCount: 1
  • /Software/Package/downloadLocation
    • minCount: 1

These are both narrowing restrictions on the externally defined properties that by default have cardinality of maxCount=1.
To be consistent with other such narrowing constraints (e.g., /Software/Package/packageVersion & /Software/SoftwareArtifact/primaryPurpose on AIPackage) these two property constraints should also explicitly assert maxCount=1.

The markdown file for DatasetPackage defines the following property constraints:

  • /Core/Artifact/originatedBy
    • minCount: 1
  • /Software/Package/downloadLocation
    • minCount: 1

These are both narrowing restrictions on the externally defined properties that by default have cardinality of maxCount=1.
To be consistent with other such narrowing constraints (e.g., /Software/SoftwareArtifact/primaryPurpose on DatasetPackage) these two property constraints should also explicitly assert maxCount=1.

@zvr
Copy link
Member

zvr commented Apr 9, 2024

I don't think this is needed.

The externally defined properties already have cardinality 0..1 (minCount = 0 and maxCount = 1).

When changing minCount to 1, this changes the cardinality to 1..1 -- it does not change it to 1..*.

To put it differently, minCount and maxCount are handled independently. Changing one does not affect the other.

@zvr
Copy link
Member

zvr commented Apr 9, 2024

Closed via #704

@zvr zvr closed this as completed Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Profile:AI Artificial intelligence profile Profile:Dataset
Projects
None yet
Development

No branches or pull requests

3 participants