Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsonMapper is mentioned as a param but not used #10

Closed
ek08 opened this issue Mar 7, 2021 · 2 comments
Closed

jsonMapper is mentioned as a param but not used #10

ek08 opened this issue Mar 7, 2021 · 2 comments

Comments

@ek08
Copy link
Contributor

ek08 commented Mar 7, 2021 •
edited
Loading

tools-java/src/main/java/org/spdx/tools/schema/OwlToJsonSchema.java

Line 101 in 8846a18

* @param jsonMapper

For the method toArrayPropertySchema(OntClass ontClass, int min) of https://github.com/spdx/tools-java/tree/master/src/main/java/org/spdx/tools/schema/OwlToJsonSchema.java

tools-java/src/main/java/org/spdx/tools/schema/OwlToJsonSchema.java

Line 105 in 8846a18

private JsonNode toArrayPropertySchema(OntClass ontClass, int min) {

jsonMapper is mentioned as a param but it is not used as a parameter in the function
@goneall
Copy link
Member

goneall commented Mar 7, 2021

Looks like the JavaDoc param should just be removed - @ek08 feel free to submit a PR

This was referenced Mar 8, 2021
Merged
Merged
@goneall
Copy link
Member

goneall commented Jun 18, 2021

Resolved with PR #11

@goneall goneall closed this as completed Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@goneall @ek08