Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated SetOutput func with SetOut and SetErr everywhere #1071

Closed
xchapter7x opened this issue Apr 1, 2020 · 1 comment
Closed

Replace deprecated SetOutput func with SetOut and SetErr everywhere #1071

xchapter7x opened this issue Apr 1, 2020 · 1 comment
Labels
area/lib Methods and functions that exist in the cobra library and consumed by users kind/feature A feature request for cobra; new or enhanced behavior

Comments

@xchapter7x
Copy link
Contributor

Follow on for this PR: #1053

We should remove all usage of deprecated SetOutput and replace with SetOut & SetErr

command.go|221 col 4| // SetOutput sets the destination for usage and error messages.
command.go|224 col 19| func (c *Command) SetOutput(output io.Writer) {
command.go|1403 col 11| c.flags.SetOutput(c.flagErrorBuf)
command.go|1431 col 12| c.lflags.SetOutput(c.flagErrorBuf)
command.go|1457 col 12| c.iflags.SetOutput(c.flagErrorBuf)
command.go|1485 col 12| c.pflags.SetOutput(c.flagErrorBuf)
command.go|1495 col 10| c.flags.SetOutput(c.flagErrorBuf)
command.go|1497 col 11| c.pflags.SetOutput(c.flagErrorBuf)
command.go|1614 col 19| c.parentsPflags.SetOutput(c.flagErrorBuf)

doc/md_docs.go|31 col 8| flags.SetOutput(buf)
doc/md_docs.go|39 col 14| parentFlags.SetOutput(buf)

doc/rest_docs.go|31 col 8| flags.SetOutput(buf)
doc/rest_docs.go|40 col 14| parentFlags.SetOutput(buf)
@xchapter7x xchapter7x mentioned this issue Apr 1, 2020
Merged
@jharshman jharshman added area/lib Methods and functions that exist in the cobra library and consumed by users kind/feature A feature request for cobra; new or enhanced behavior labels Apr 1, 2020
@jpmcb jpmcb mentioned this issue Apr 2, 2020
Merged
@jharshman jharshman mentioned this issue Apr 2, 2020
Merged
@jharshman
Copy link
Collaborator

Some of those reference pflag. References in Cobra resolved in ##1078

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/lib Methods and functions that exist in the cobra library and consumed by users kind/feature A feature request for cobra; new or enhanced behavior
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xchapter7x @jharshman