Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fish output redirection #1247

Merged
merged 1 commit into from
Oct 6, 2020
Merged

fix: fish output redirection #1247

merged 1 commit into from
Oct 6, 2020

Conversation

matejvasek
Copy link
Contributor

resolves #1246

@CLAassistant
Copy link

CLAassistant commented Oct 5, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@marckhouzam
Copy link
Collaborator

Thanks @matejvasek, to make sure we don't break this again, could you put a comment not to use &> because Fish 3.0 does not support it?

@matejvasek
fix: fish output redirection
9e77b2f 
Signed-off-by: Matej Vasek <mvasek@redhat.com>
@matejvasek
Copy link
Contributor Author

@marckhouzam comment added.

@matejvasek matejvasek mentioned this pull request Oct 5, 2020
Merged
marckhouzam
marckhouzam approved these changes Oct 6, 2020
View reviewed changes
Copy link
Collaborator

@marckhouzam marckhouzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
I've tested this with Fish 3.1 and things continue to work as expected.

@jharshman this looks safe.

jharshman
jharshman approved these changes Oct 6, 2020
View reviewed changes
Copy link
Collaborator

@jharshman jharshman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @matejvasek for your PR and @marckhouzam for your review!

@jharshman jharshman merged commit b97b5ea into spf13:master Oct 6, 2020
@dependabot dependabot bot mentioned this pull request Mar 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jharshman jharshman jharshman approved these changes

@marckhouzam marckhouzam marckhouzam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fish completion error
4 participants
@matejvasek @CLAassistant @marckhouzam @jharshman