You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The implementation uses a lot of unsigned long long for sizes of buffers and assumes that it's the same size as the size_t data type: it's passed to e.g. memmove and memcpy a lot. But on 32-bit x86 at least, sizeof(size_t) < sizeof(unsigned long long). This can lead to a lot of compiler warnings.
It would probably clean up the source code a lot to switch over to stdint.h types and use stddef.h for size_t whenever relevant. I'm not preparing a PR for this right now, as there are some large PRs open, but I am posting this as an issue for future reference.
The text was updated successfully, but these errors were encountered:
The implementation uses a lot of
unsigned long long
for sizes of buffers and assumes that it's the same size as thesize_t
data type: it's passed to e.g.memmove
andmemcpy
a lot. But on 32-bit x86 at least,sizeof(size_t) < sizeof(unsigned long long)
. This can lead to a lot of compiler warnings.It would probably clean up the source code a lot to switch over to
stdint.h
types and usestddef.h
forsize_t
whenever relevant. I'm not preparing a PR for this right now, as there are some large PRs open, but I am posting this as an issue for future reference.The text was updated successfully, but these errors were encountered: