Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable default smartquotes for zh_CN and zh_TW #12875

Merged
merged 4 commits into from
Sep 27, 2024
Merged

Disable default smartquotes for zh_CN and zh_TW #12875

merged 4 commits into from
Sep 27, 2024

Conversation

khanxmetu
Copy link
Contributor

@khanxmetu khanxmetu commented Sep 9, 2024 •
edited by AA-Turner
Loading

Subject: Disable default smartquotes for zh_CN and zh_TW

Feature or Bugfix

  • Bugfix

Purpose

Relates

@AA-Turner AA-Turner changed the title Closes #12874: Disable default smartquotes for zh_CN and zh_TW Disable default smartquotes for zh_CN and zh_TW Sep 18, 2024
@picnixz
Copy link
Member

picnixz commented Sep 26, 2024

Merging HEAD into this branch to avoid mypy failures.

picnixz
picnixz approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@picnixz picnixz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems right to me. Are there other languages that suffer from this?

Oh by the way, I think I want a CHANGELOG entry. This is a change in the output being produced so it would be good to indicate that the support has been disabled for those languages.

@khanxmetu
Copy link
Contributor Author

Seems right to me. Are there other languages that suffer from this?

Not that I'm aware of... The languages affected by the problem of not having word separators are Scriptio continua. In modern writing and among those that Sphinx supports only Chinese and Japanese are affected.

Oh by the way, I think I want a CHANGELOG entry. This is a change in the output being produced so it would be good to indicate that the support has been disabled for those languages.

Added

@picnixz
Copy link
Member

picnixz commented Sep 27, 2024

Once the CI/CD passes, I'll merge it!

@picnixz picnixz merged commit 0a162fa into sphinx-doc:master Sep 27, 2024
22 checks passed
@picnixz
Copy link
Member

picnixz commented Sep 27, 2024

Thank you!

@AA-Turner AA-Turner added this to the 8.1.x milestone Oct 6, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Danysharma00 Danysharma00 Danysharma00 approved these changes

@picnixz picnixz picnixz approved these changes

Assignees
No one assigned
Labels
i18n internals:config
Projects
None yet
Milestone
8.1.0
Development

Successfully merging this pull request may close these issues.

Inconsistent smart quotes for zh_CN and zh_TW
5 participants
@khanxmetu @picnixz @Danysharma00 @AA-Turner @jayaddison