-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support placeholders for years in copyright #12910
Merged
AA-Turner
merged 11 commits into
sphinx-doc:master
from
AA-Turner:copyright-placeholders
Oct 4, 2024
Merged
Changes from 6 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
1a5d1b4
Support placeholders for years in copyright
AA-Turner 35539e5
Support placeholders for years in copyright
AA-Turner 766f169
rename & shorten
AA-Turner 0907767
Merge branch 'master' into copyright-placeholders
AA-Turner 2bcd37e
Merge branch 'master' into copyright-placeholders
AA-Turner ca911b5
post-merge
AA-Turner a10dbeb
Add test and docs
AA-Turner 2f806dd
lint
AA-Turner ba208eb
copyright_year_placeholders -> evaluate_copyright_placeholders
AA-Turner 818f3e0
CHANGES
AA-Turner 0cc78bd
Nicer link format
AA-Turner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although I think we should support this templating for other projects, I have a strong preference for using constant/static copyright notices where possible (although I fully admit that adding supporting tooling to detect cases where they're out-of-date could be useful).
Given that, and the fact that we update most of the copyright notices throughout the codebase manually each year, I wonder whether we should do the same here.