From fd462147c76ee66f96e882fdef334449f5eedbd8 Mon Sep 17 00:00:00 2001 From: Ryan Northey Date: Thu, 24 Aug 2023 16:02:15 +0100 Subject: [PATCH 1/4] deps: Make Sphinx optional Signed-off-by: Ryan Northey --- .github/workflows/test.yml | 1 + pyproject.toml | 6 +++--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 794d170..3e35172 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -45,6 +45,7 @@ jobs: run: | python -m pip install --upgrade pip python -m pip install .[test] + python -m pip install .[standalone] - name: Test with pytest run: python -m pytest -vv --durations 25 diff --git a/pyproject.toml b/pyproject.toml index 72dd83c..2dbd6e0 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -39,9 +39,6 @@ classifiers = [ "Topic :: Text Processing", "Topic :: Utilities", ] -dependencies = [ - "Sphinx>=5", -] dynamic = ["version"] [project.optional-dependencies] @@ -53,6 +50,9 @@ lint = [ "mypy", "docutils-stubs", ] +standalone = [ + "sphinx > 5", +] [[project.authors]] name = "Georg Brandl" From fb9e815b32672542e974ce666675acbfec6a5ae0 Mon Sep 17 00:00:00 2001 From: Ryan Northey Date: Fri, 1 Sep 2023 11:23:51 +0100 Subject: [PATCH 2/4] updates Signed-off-by: Ryan Northey --- .github/workflows/test.yml | 3 +-- CHANGES | 5 +++++ sphinxcontrib/qthelp/__init__.py | 1 + 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 3e35172..8cd7db1 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -44,8 +44,7 @@ jobs: - name: Install dependencies run: | python -m pip install --upgrade pip - python -m pip install .[test] - python -m pip install .[standalone] + python -m pip install .[test,standalone] - name: Test with pytest run: python -m pytest -vv --durations 25 diff --git a/CHANGES b/CHANGES index d5e31c7..37aa19d 100644 --- a/CHANGES +++ b/CHANGES @@ -1,3 +1,8 @@ +Release 1.0.6 (Pending) +========================== + +* Fix circular dependency with Sphinx that caused failure in DAG-based package management + Release 1.0.5 (2023-08-09) ========================== diff --git a/sphinxcontrib/qthelp/__init__.py b/sphinxcontrib/qthelp/__init__.py index 3d3f363..e840c6d 100644 --- a/sphinxcontrib/qthelp/__init__.py +++ b/sphinxcontrib/qthelp/__init__.py @@ -253,6 +253,7 @@ def get_project_files(self, outdir: str | os.PathLike[str]) -> list[str]: def setup(app: Sphinx) -> dict[str, Any]: + app.require_sphinx('5.0') app.setup_extension('sphinx.builders.html') app.add_builder(QtHelpBuilder) app.add_message_catalog(__name__, path.join(package_dir, 'locales')) From e5c2bfdeac9c45cc24d905af2a66c62ec2ff9cdf Mon Sep 17 00:00:00 2001 From: Adam Turner <9087854+AA-Turner@users.noreply.github.com> Date: Sat, 13 Jan 2024 02:06:22 +0000 Subject: [PATCH 3/4] Apply suggestions from code review --- CHANGES | 2 +- pyproject.toml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/CHANGES b/CHANGES index 37aa19d..6c4dec2 100644 --- a/CHANGES +++ b/CHANGES @@ -1,4 +1,4 @@ -Release 1.0.6 (Pending) +Release 1.0.6 (unreleased) ========================== * Fix circular dependency with Sphinx that caused failure in DAG-based package management diff --git a/pyproject.toml b/pyproject.toml index 2dbd6e0..12bf71f 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -51,7 +51,7 @@ lint = [ "docutils-stubs", ] standalone = [ - "sphinx > 5", + "Sphinx>=5", ] [[project.authors]] From 8758736e38c12337d0f8202bea4f4bf778116bd2 Mon Sep 17 00:00:00 2001 From: Adam Turner <9087854+AA-Turner@users.noreply.github.com> Date: Sat, 13 Jan 2024 02:12:25 +0000 Subject: [PATCH 4/4] Apply suggestions from code review --- CHANGES | 4 +++- pyproject.toml | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/CHANGES b/CHANGES index 6c4dec2..6f37462 100644 --- a/CHANGES +++ b/CHANGES @@ -1,7 +1,9 @@ Release 1.0.6 (unreleased) ========================== -* Fix circular dependency with Sphinx that caused failure in DAG-based package management +* Remove Sphinx as a required dependency, as circular dependencies may cause + failure with package managers that expect a directed acyclic graph (DAG) + of dependencies. Release 1.0.5 (2023-08-09) ========================== diff --git a/pyproject.toml b/pyproject.toml index 12bf71f..a68d669 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -39,6 +39,7 @@ classifiers = [ "Topic :: Text Processing", "Topic :: Utilities", ] +dependencies = [] dynamic = ["version"] [project.optional-dependencies]