Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task(dotnet): Add x-spice-user-agent header to Runtime requests #6

Closed
peasee opened this issue Sep 17, 2024 · 0 comments · Fixed by #7
Closed

task(dotnet): Add x-spice-user-agent header to Runtime requests #6

peasee opened this issue Sep 17, 2024 · 0 comments · Fixed by #7
Assignees
@peasee
Labels
task
Milestone
v0.2.0

Comments

@peasee
Copy link
Contributor

peasee commented Sep 17, 2024

What

Add x-spice-user-agent as a header to all HTTP and Flight requests to the Runtime, for the Runtime to determine the originating SDK version.

The header should be passed as a value like:

spice.js 0.1.0 (Pop!_OS 22.04 LTS)

e.g. {sdk name} {sdk version} ({os distribution})
@peasee peasee added the task label Sep 17, 2024
@peasee peasee added this to the v0.1.1 milestone Sep 17, 2024
@peasee peasee self-assigned this Sep 17, 2024
@peasee peasee changed the title task: Add x-spice-user-agent header to Runtime requests task(dotnet): Add x-spice-user-agent header to Runtime requests Sep 17, 2024
@peasee peasee mentioned this issue Sep 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peasee peasee

Labels
task
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging a pull request may close this issue.

feat: add x-spice-user-agent-header spiceai/spice-dotnet
1 participant
@peasee