Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: create contributing.md #2915

Merged
merged 4 commits into from
Mar 23, 2024
Merged

docs: create contributing.md #2915

merged 4 commits into from
Mar 23, 2024

Conversation

b-chen00
Copy link
Contributor

@b-chen00 b-chen00 commented Mar 21, 2024

Let me know if any changes are needed.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@rxri rxri changed the title docs(contributing.md): create contributing.md docs: create contributing.md Mar 22, 2024
@rxri rxri changed the title docs: create contributing.md docs: create contributing.md Mar 22, 2024
@b-chen00
Copy link
Contributor Author

Messed up the commit message but fixed with the force pushes

@rxri
Copy link
Member

rxri commented Mar 22, 2024

commit message(s) inside pr don't matter as long as the pr title follows conventional commit spec

@b-chen00 b-chen00 requested a review from rxri March 22, 2024 19:11
CONTRIBUTING.md Outdated Show resolved Hide resolved
@rxri
Copy link
Member

rxri commented Mar 22, 2024

Ignore the linter

Copy link
Member

@afonsojramos afonsojramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@afonsojramos afonsojramos merged commit 9ef07f9 into spicetify:master Mar 23, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants