Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The java-spiffe modules contain split packages which break the Java Modules (JPMS) #108

Open
thomasrichner-oviva opened this issue Jan 12, 2023 · 0 comments

Comments

@thomasrichner-oviva
Copy link
Contributor

The Java Platform Module System (JPMS) introduced in Java 9 does not allow for split-packages. That is the same package in multiple JARs.

As a matter of fact java-spiffe has some split packages though, this breaks libraries that want to write modules depending on java-spiffe.

At least one of the offending packages leads to a compilation error: the unnamed module reads package io.spiffe.workloadapi.internal from both grpc.netty.macos.aarch64 and java.spiffe.core

Ideally the split package is removed by e.g. moving io.spiffe.workloadapi.internal in grpc.netty.macos.aarch64 to io.spiffe.workloadapi.grpc.netty.macosa.arch64.internal or similar.

Even better would be to define a proper java module for java-spiffe e.g. write a module-info.java file. This would also prevent future introduction of split packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant