From a4b66aa2412511e125212f3f0dea1425cec87ba9 Mon Sep 17 00:00:00 2001 From: Mark Vulfson Date: Fri, 16 Oct 2020 11:03:35 -0700 Subject: [PATCH] fix(docker): use a more concrete reason for when the cache is empty (#893) Docker triggers might not send an event to echo if the cache was empty (e.g. instance just came) Adding a reason to event to metric for this case --- .../com/netflix/spinnaker/igor/docker/DockerMonitor.groovy | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/igor-web/src/main/groovy/com/netflix/spinnaker/igor/docker/DockerMonitor.groovy b/igor-web/src/main/groovy/com/netflix/spinnaker/igor/docker/DockerMonitor.groovy index dc6b61be5..27336ae62 100644 --- a/igor-web/src/main/groovy/com/netflix/spinnaker/igor/docker/DockerMonitor.groovy +++ b/igor-web/src/main/groovy/com/netflix/spinnaker/igor/docker/DockerMonitor.groovy @@ -159,7 +159,11 @@ class DockerMonitor extends CommonPollingMonitor if (sendEvents && item.sendEvent) { postEvent(delta.cachedImages, item.image, item.imageId) } else { + if (!sendEvents) { registry.counter(missedNotificationId.withTags("monitor", getName(), "reason", "fastForward")).increment() + } else { + registry.counter(missedNotificationId.withTags("monitor", getName(), "reason", "skippedDueToEmptyCache")).increment() + } } } }