fix(codebuild): set region when creating sts client #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a race condition where default region could not be found, causing STS client failed to be created. To fix it, we set STS client region to what specified in the codebuild halyard config. Fixed spinnaker/spinnaker#5974
clareliguori
approved these changes
Aug 20, 2020
|
UPDATE: the fix I have applied to 1.21 code base, although lets igor start now and even add CodeBuild accounts in Spinnaker deck, still shows signs of distress in Igor's log. The service crashes no longer, but CodeBuild functionality is still unavailable: |
|
can we also have fix ported to 1.21? My local build with the fix works alright after I have added account access credentials to CodeBuild section |
clareliguori
added
the
backport-candidate
|
@Mergifyio backport release-1.21.x |
mergify bot
pushed a commit
that referenced
this pull request
Aug 22, 2020
There's a race condition where default region could not be found, causing STS client failed to be created. To fix it, we set STS client region to what specified in the codebuild halyard config. Fixed spinnaker/spinnaker#5974 Co-authored-by: Clare Liguori <liguori@amazon.com> (cherry picked from commit babd23f)
|
Command
|
|
@Kaixiang-AWS @clareliguori in order for a PR to be backported to previous releases, it must meet the documented criteria. I see that the following is missing:
I see that this issue may have been there since the beginning, meaning that it doesn't fix a regression. Can you confirm? |
|
Here is my 2 million dollars: it's not a feature, it's a bug in AWS CodeBuild Spinnaker integration (which is claimed to have worked but apparently didn't), the fix is easily portable, there is no need for anyone to wait till 1.23, since it's 1.22 hasn't been even released. And it really blocks me at least from using AWS CodeBuild |
|
I understand that this is a bug, but at this point only fixes for regressions and security vulenrabilities are allowed into release branches. Until that policy is changed, non-regression bug fixes will need to wait for the next release. |
german-muzquiz
removed
the
backport-candidate
|
1.21 is the most current release. I honestly expected the Spinnaker dev team to be more...agile, not putting a policy/process over customer's needs, a policy that makes little sense in this context. 1.23 is not even scheduled |
|
@german-muzquiz I missed seeing the updated release branch criteria. You are correct, this is not a regression. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a race condition where default region could not be found, causing
STS client failed to be created. To fix it, we set STS client region to
what specified in the codebuild halyard config.
Fixed spinnaker/spinnaker#5974